FileVectorStore should create folder if it doesn't exist

[amitavroy]

Currently, the FileVectorStore throws an exception if a FileVectorStore doesn't exist on the mentioned storage path.

I can see a custom Exception class VectorStoreException has been created and thrown.

Wouldn't it be better if we go ahead and create the directory? Because it is not a delete, it is not a dangerous action. And hence, it can be a better experience.

Or it was an intention decision.

If you agree, the current code:

public function __construct(
    protected string $directory,
    protected int $topK = 4,
    protected string $name = 'neuron',
    protected string $ext = '.store'
) {
    if (!is_dir($this->directory)) {
        throw new VectorStoreException("Directory '{$this->directory}' does not exist");
    }
}

Can be replaced with something like:

public function __construct(
    protected string $directory,
    protected int $topK = 4,
    protected string $name = 'neuron',
    protected string $ext = '.store'
) {
    if (!is_dir($this->directory)) {
        if (!mkdir($this->directory, 0755, true)) {
            throw new VectorStoreException("Directory doesn't exist and failed to create directory '{$this->directory}'");
        }
    }
}

[amitavroy]

Hi @ilvalerione just wanted to understand this makes sense to you.

[ilvalerione]

Absolutely it has a lot of sense.

[amitavroy]

Thanks, I have done that and raise a PR.

here is the link: #414