Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope of functions defined in quadric.c #7

Closed
gllmflndn opened this issue Dec 5, 2022 · 5 comments
Closed

Scope of functions defined in quadric.c #7

gllmflndn opened this issue Dec 5, 2022 · 5 comments

Comments

@gllmflndn
Copy link

Would it be OK to add a static keyword to all functions in quadric.c apart from quadric_simplify_mesh, laplacian_smoothHC and laplacian_smooth (and perhaps expose laplacian_smooth in quadric.h)?

It also seems that time.h does not need to be included.

@neurolabusc
Copy link
Owner

@gllmflndn please close if the latest commit resolves this issue.

@gllmflndn
Copy link
Author

Thanks! Is there a reason why symMatDet and vCross in quadric.c were not included to have a static keyword?

neurolabusc added a commit that referenced this issue Dec 6, 2022
More static functions (#7)
@neurolabusc
Copy link
Owner

Sorry, missed those. Do you know an easy way to report all the global functions in C code?

@neurolabusc
Copy link
Owner

To answer my own question, compile with -Wmissing-prototypes

@gllmflndn
Copy link
Author

Thanks again! I didn't know about -Wmissing-prototypes - it might come in handy. The static keyword matters to me because of an odd bug I observed with the -Bsymbolic-functions compilation flag with Octave (bug #55363).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants