Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DurationChoices by JobIntervalChoices #18286

Open
alehaa opened this issue Dec 30, 2024 · 0 comments
Open

Replace DurationChoices by JobIntervalChoices #18286

alehaa opened this issue Dec 30, 2024 · 0 comments
Labels
status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application

Comments

@alehaa
Copy link
Contributor

alehaa commented Dec 30, 2024

NetBox version

v4.2-beta1

Feature type

Change to existing functionality

Triage priority

I volunteer to perform this work (if approved)

Proposed functionality

During the implementation of #17716, I added the JobIntervalChoices to simplify job scheduling. At the time of writing this PR, I wasn't aware that there was already a DurationChoices in the extras module used by the script form.

I suggest replacing it with the new JobIntervalChoices and also integrating its missing choices for "12 hours" and "30 days".

Use case

Code deduplication and increasing maintainability.

Database changes

None.

External dependencies

DurationChoices has never been part of a public API, so I think there are no side effects.

@alehaa alehaa added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

1 participant