Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional Q-in-Q role on VLAN Groups #18279

Open
sleepinggenius2 opened this issue Dec 30, 2024 · 0 comments
Open

Allow optional Q-in-Q role on VLAN Groups #18279

sleepinggenius2 opened this issue Dec 30, 2024 · 0 comments
Labels
beta Concerns a bug/feature in a beta release status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application

Comments

@sleepinggenius2
Copy link
Contributor

NetBox version

v4.2-beta1

Feature type

Data model extension

Triage priority

N/A

Proposed functionality

Copy the qinq_role field from the Vlan model to the VlanGroup model. Add validation to only allow VLANs of the same role in the group.

If the Q-in-Q role is empty, I think it makes sense to allow VLANs with any Q-in-Q role, but I could also see an argument to only allow VLANs without a Q-in-Q role set and to add an additional Q-in-Q role of "Any" or "Mixed" to the VLAN Group model to explicitly allow VLANs with non-empty Q-in-Q roles as well.

Use case

If using a VLAN Group to document the VLANs available on an ENNI, they must all be SVLANs, likewise on a UNI they must all be CVLANs, so it would be nice to have the system be able to enforce that out of the box.

Database changes

Copy the qinq_role field from the Vlan model to the VlanGroup model.

External dependencies

None

@sleepinggenius2 sleepinggenius2 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Dec 30, 2024
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Concerns a bug/feature in a beta release status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants