Skip to content

Improve Newsletter Form Submission: Add Error Icon and Use Fetch API with Async/Await #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Precious-Bob opened this issue Jun 3, 2024 · 3 comments

Comments

@Precious-Bob
Copy link

Good day Kamil, I tried subscribing to the NestJS newsletter and noticed that the success icon activates even when the POST request fails. To improve the user experience and code quality, I would love to work on the following changes:

Add an Error Icon: Introduce an error icon to inform users if their subscription request fails, providing clear feedback on the submission status.
Use Fetch API with Async/Await: Update the codebase to utilize the Fetch API and async/await for handling the form submission, replacing the existing method for better readability and modern JavaScript practices.

@kamilmysliwiec
Copy link
Member

PRs are more than welcome!

@apoorvpathak
Copy link

a spinner would be nice too, i am working on the PR

@kamilmysliwiec
Copy link
Member

Let's track this here #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants