Don't apply update when update already in progress #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8 Some events in nerves-hub.org will trigger an update message to be sent, such as editing a deployment/device (changing the name and saving, etc). If a device gets that message while it is already updating, things will crash. This shouldn't be too much of an issue because the whole channel crashes, reconnects, and gets the update message again. But it produces some nasty error that might be confusing to the user. So to help avoid this edge-case, let's just ignore update messages while in the process of updating. Should it actually be new/required, we'll get the message again on next startup after rebooting.
jjcarstens
force-pushed
the
update-in-progress
branch
from
872de94 to
cc26646
Compare
ConnorRigby
approved these changes
Feb 19, 2020
|
I have verified that this works for us. |
fhunleth
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
Some events in nerves-hub.org will trigger an update message to be sent, such as editing
a deployment/device (changing the name and saving, etc).
If a device gets that message while it is already updating, things will crash. This shouldn't
be too much of an issue because the whole channel crashes, reconnects, and gets the update
message again. But it produces some nasty error that might be confusing to the user.
So to help avoid this edge-case, let's just ignore update messages while in the process of
updating. Should it actually be new/required, we'll get the message again on next startup after
rebooting.