Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support window_size from NervesHub #46

Closed
jjcarstens opened this issue Sep 30, 2020 · 1 comment
Closed

Support window_size from NervesHub #46

jjcarstens opened this issue Sep 30, 2020 · 1 comment
Labels
good first issue Good for newcomers Hacktoberfest Would be especially useful to get done during Hacktoberfest!

Comments

@jjcarstens
Copy link
Collaborator

extty supports changing the window size of the remote console via ExTTY.window_change/3

The ConsoleChannel docs show that window_size is an optional message from the Server, but it doesn't actually have a matching handle_info clause to handle that message, so it needs to be added.

Also, this would be the counterpart to nerves-hub/nerves_hub_web#654
@jjcarstens jjcarstens added good first issue Good for newcomers Hacktoberfest Would be especially useful to get done during Hacktoberfest! labels Sep 30, 2020
@honsq90
Copy link

honsq90 commented Oct 1, 2020

i can give this a go

jjcarstens pushed a commit that referenced this issue Nov 20, 2020
@jjcarstens
Handle :window_size message (#46)
05be91c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest Would be especially useful to get done during Hacktoberfest!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@honsq90 @jjcarstens