Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report FWUP version to NervesHub #43

Closed
Mrjaco12 opened this issue Aug 28, 2020 · 3 comments
Closed

Report FWUP version to NervesHub #43

Mrjaco12 opened this issue Aug 28, 2020 · 3 comments

Comments

@Mrjaco12
Copy link
Contributor

In certain scenarios it makes sense for NervesHub to know what version of FWUP a device is running this means FWUP needs to report this data in it's communications with the NervesHub back end.
@Mrjaco12
Copy link
Contributor Author

Mrjaco12 commented Aug 28, 2020 •
edited
Loading

@fhunleth @mobileoverlord I'm creating this issue to track adding the FWUP version here and, I assume, we'll also need it in the http version. I figured this would be a good place to discuss the approach since you guys have much greater familiarity with the whole Nerves/NervesHub ecosystem than I do.

My first idea was to just grab the version from fwup via System.cmd and insert it around the time we grab other meta data from the runtime KV. Does that make sense or is there some point, before or after, that would work better?

@fhunleth
Copy link
Contributor

I like your idea.

Mrjaco12 added a commit to verypossible/nerves_hub_web that referenced this issue Aug 28, 2020
@Mrjaco12
Add a check for fwup version
0b7c487 
Why:

* We need to verify that the device fwup supports patching

This change addresses the need by:

* Grabbing fwup from channel params or controller conn depending on nerves_hub_link package
* Attach the fwup version to device.firmware_metadata
* Pass fwup version to `get_firmware_url` function
* Only make request for patch url if fwup version is >=1.6.0

Note:

* For this to work properly nerves_hub_link and nerves_hub_link_http will need to be updated to pass fwup version
* See nerves-hub/nerves_hub_link#43 for more details
Mrjaco12 added a commit to verypossible/nerves_hub_link that referenced this issue Aug 31, 2020
@Mrjaco12
Report fwup version to nerves hub
6b77a13 
Why:

* NH needs to know the fwup version to make decisions about delta updates
* Resolves Issue nerves-hub#43

This change addresses the need by:

* Grab fwup version when creating config
* Add fwup version to config params
* Add a spec to check that fwup version key is present
@Mrjaco12 Mrjaco12 mentioned this issue Aug 31, 2020
Merged
mobileoverlord pushed a commit that referenced this issue Sep 1, 2020
@Mrjaco12 @mobileoverlord
Report fwup version to nerves hub
77bd958 
Why:

* NH needs to know the fwup version to make decisions about delta updates
* Resolves Issue #43

This change addresses the need by:

* Grab fwup version when creating config
* Add fwup version to config params
* Add a spec to check that fwup version key is present
mobileoverlord pushed a commit to nerves-hub/nerves_hub_web that referenced this issue Sep 17, 2020
@Mrjaco12 @mobileoverlord
Add a check for fwup version
06c1172 
Why:

* We need to verify that the device fwup supports patching

This change addresses the need by:

* Grabbing fwup from channel params or controller conn depending on nerves_hub_link package
* Attach the fwup version to device.firmware_metadata
* Pass fwup version to `get_firmware_url` function
* Only make request for patch url if fwup version is >=1.6.0

Note:

* For this to work properly nerves_hub_link and nerves_hub_link_http will need to be updated to pass fwup version
* See nerves-hub/nerves_hub_link#43 for more details
@jjcarstens
Copy link
Collaborator

Released in https://github.com/nerves-hub/nerves_hub_link/releases/tag/v0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fhunleth @Mrjaco12 @jjcarstens