Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect PP complement throwing validator error #143

Open
bwaldon opened this issue Nov 12, 2024 · 4 comments
Open

Indirect PP complement throwing validator error #143

bwaldon opened this issue Nov 12, 2024 · 4 comments

Comments

@bwaldon
Copy link
Collaborator

bwaldon commented Nov 12, 2024

https://github.com/nert-nlp/legal-cgel/blob/659939c45cb7269b509072ca6715e5f3584b963b/datasets/oneoff/pdf/id295a8bc5-2a73-11ef-ba6d-a9961dfb011e_0_0.pdf

PP indirect complement "as Congress may deem necessary..."

The error:

line 868, in validate
    assert ch.constituent=='PP' and c_d in {('Nom','Comp'), ('Nom','Comp_ind'), ('VP','Comp'), ('VP','Particle'), ('VP','PredComp'), ('AdjP','Comp'), ...

(No error when I remove the PP from the tree).

@bwaldon bwaldon changed the title Indirect PP complement throwing validator error: Indirect PP complement throwing validator error Nov 12, 2024
@nschneid
Copy link
Contributor

In particular:

image

@BrettRey do you think it's valid to consider this an indirect complement? If so we need to relax our previous assumptions about where indirect complements are allowed.

@BrettRey
Copy link
Collaborator

It does indeed look like an indirect complement.

@nschneid
Copy link
Contributor

In the VP? I guess another alternative would be to say "from time to time" is a supplement within the NP. Or that there's a gap.

@BrettRey
Copy link
Collaborator

Yes, the supplement analysis seems obvious, now that you mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants