Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage is missing a .DirIcon file #1

Closed
probonopd opened this issue Jun 20, 2019 · 5 comments
Closed

AppImage is missing a .DirIcon file #1

probonopd opened this issue Jun 20, 2019 · 5 comments

Comments

@probonopd
Copy link

probonopd commented Jun 20, 2019

The AppImage is missing a .DirIcon file.

Possibly this is an electron-builder issue?

Reference:
AppImage/appimage.github.io#1646

@neopostmodern
Copy link
Owner

I don't really understand what happened to the issue you mentioned (electron-userland/electron-builder#3988) -- do I just need to update electron-builder? Or is it something to be applied manually? (If so, a PR would be very welcome since you seem to understand what the underlying issue is about. Otherwise I'll read into this in a week or two.)

@probonopd
Copy link
Author

I think this will be fixed in the next electron-builder release, once it becomes available and once this project is updated to use that electron-builder version. Thanks for your consideration!

@neopostmodern
Copy link
Owner

@probonopd — could you please check if this is fixed in the latest release? https://github.com/neopostmodern/wohnungsbot/releases/tag/v1.1.0

probonopd added a commit to AppImage/appimage.github.io that referenced this issue Sep 21, 2019
@probonopd
Copy link
Author

@neopostmodern
Copy link
Owner

Cleaning up, feel free to re-open @probonopd if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants