Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pageserver: improve initdb observability #10423

Closed
VladLazar opened this issue Jan 16, 2025 · 0 comments · Fixed by #10434
Closed

pageserver: improve initdb observability #10423

VladLazar opened this issue Jan 16, 2025 · 0 comments · Fixed by #10434
Labels
a/observability Area: related to observability c/storage/pageserver Component: storage: pageserver c/storage Component: storage

Comments

@VladLazar
Copy link
Contributor

When bootstrapping a new timeline upon creation we have to run initdb (run_initdb in tenant.rs).
Since it spawns a new process, we have a semaphore for concurrency limiting INITDB_SEMAPHORE.

There's very little observability here. We should:

  • Add a global metric for the number of initdbs running
  • Observe long initdbs themselves (either via logs or a new global histogram)
  • (optional) Observe long semaphore waits
@VladLazar VladLazar added a/observability Area: related to observability c/storage Component: storage c/storage/pageserver Component: storage: pageserver labels Jan 16, 2025
@VladLazar VladLazar mentioned this issue Jan 16, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@VladLazar
pageserver: add initdb metrics (#10434)
6975228 
## Problem

Initdb observability is poor.

## Summary of changes

Add some metrics so we can figure out which part, if any, is slow.

Closes #10423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a/observability Area: related to observability c/storage/pageserver Component: storage: pageserver c/storage Component: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pageserver: add initdb metrics neondatabase/neon
1 participant
@VladLazar