-
-
Notifications
You must be signed in to change notification settings - Fork 200
Open
Labels
aiarchitectureArchitecture related issuesArchitecture related issuescoreCore framework functionalityCore framework functionalityenhancementNew feature or requestNew feature or request
Description
Goal
Establish the Neo.data.connection.Base hierarchy and fix the abstraction leak in Neo.data.parser.Stream by extracting its network transport logic.
Context
A Parser should strictly focus on deserialization and shaping data (e.g., converting a text stream into JSON records). Currently, Neo.data.parser.Stream has fetch() and AbortController logic hardcoded into its read() method. This makes it a Connection in disguise and violates the single responsibility principle.
Acceptance Criteria
- Create
src/data/connection/Base.mjs. - Refactor
Neo.data.connection.FetchandXhrto extend this new Base class. - Create a new Connection (e.g.,
connection.Streamor enhanceconnection.Fetch) that handles thefetch()request and returns theReadableStream. - Refactor
Neo.data.parser.Stream: Remove thefetch()call. The parser should now accept theReadableStreamprovided by the Connection, process the NDJSON/JSONL chunks, and yield records. - Ensure the
Pipelineclass correctly routes the output of theConnectioninto theParser.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
aiarchitectureArchitecture related issuesArchitecture related issuescoreCore framework functionalityCore framework functionalityenhancementNew feature or requestNew feature or request