Skip to content

Commit 12df0a5

Browse files
committed
Make sqs/sns arn optional
1 parent 9cb2b89 commit 12df0a5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,11 @@ let pubsub_telemetry_layer = OtelLambdaLayer::pubsub(
151151
```rust
152152
let sqs_telemetry_layer = OtelLambdaLayer::sqs(
153153
provider,
154-
"arn:aws:sqs:us-east-2:123456789012:MyQueue",
154+
Some("arn:aws:sqs:us-east-2:123456789012:MyQueue"),
155155
);
156156
let sns_telemetry_layer = OtelLambdaLayer::sns(
157157
provider,
158-
"arn:aws:sns:us-east-2:123456789012:MyTopic",
158+
Some("arn:aws:sns:us-east-2:123456789012:MyTopic"),
159159
);
160160
```
161161

src/middleware/lambda/context.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,13 @@ impl OtelLambdaLayer<GenericLambdaService> {
116116
}
117117

118118
impl OtelLambdaLayer<PubSubLambdaService> {
119-
pub fn sqs(provider: TracerProvider, queue_arn: impl Into<StringValue>) -> Self {
120-
Self::pubsub(provider, "AmazonSQS", Some(queue_arn))
119+
pub fn sqs(provider: TracerProvider, queue_arn: impl Into<OptionalValue>) -> Self {
120+
Self::pubsub(provider, "AmazonSQS", queue_arn)
121121
}
122122
}
123123

124124
impl OtelLambdaLayer<PubSubLambdaService> {
125-
pub fn sns(provider: TracerProvider, topic_arn: impl Into<StringValue>) -> Self {
126-
Self::pubsub(provider, "AmazonSNS", Some(topic_arn))
125+
pub fn sns(provider: TracerProvider, topic_arn: impl Into<OptionalValue>) -> Self {
126+
Self::pubsub(provider, "AmazonSNS", topic_arn)
127127
}
128128
}

0 commit comments

Comments
 (0)