-
Notifications
You must be signed in to change notification settings - Fork 25
Description
It has occurred to me that the way FFTs are visualized both in this package as well as in publications is in what I call a 'wide' orientation. In an 'width' orientation, nodes of the tree are arranged horizontally based on the exit structure of the preceding node. That is, a node below a 'left-exit' node will be placed to the right of the node above it, while a node below a 'right-exit' node will be placed to the left of the node above it.
By contrast, consider what I would call a 'vertical' orientation, where nodes are always shown vertically stacked on top of each other, regardless of the node exit.
See my crude drawing (not to scale!) below

(I'm pretty sure I've seen both of these versions in publications but I don't have any examples handy)
I can think of a few benefits to showing trees using this vertical orientation within FFTrees()
:
- Vertical orientations are simpler to create than wide, reducing code. There's a bunch of code in https://github.com/ndphillips/FFTrees/blob/master/R/plotFFTrees_function.R that figures out where elements should be placed based on the location of the prior node). If we used a vertical orientation, we could remove all of that logic.
- Vertical orientations will lead to more consistent and predictable visualization dimensions. If I was embedding plots of FFTrees in a dashboard or paper, I'd appreciate this!
- Vertical orientations emphasize the simplicity of ffts. That is, unlike information in 'standard' trees, information in ffts flows in one direction only -- vertically.
@hneth curious what you think about this.
- Is this distinction between wide and vertical trees something you've thought of or come across before?
- Do you agree or disagree with my suggested benefits above? Are there any I missed? What about cons?