-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
bugSomething isn't workingSomething isn't working
Description
When verifying the existing of jupyter in user's environment, we rely on this command:
jupyter-forward/jupyter_forward/core.py
Line 218 in 64a2c56
| check_jupyter_status = 'which jupyter' |
However, this command isn't robust enough because having jupyter install doesn't necessary mean that jupyterlab is also installed.
Due to this, when user's have jupyter installed and jupyterlab is not installed, this command
jupyter-forward/jupyter_forward/core.py
Line 187 in 64a2c56
| command = rf'jupyter lab --no-browser --ip={self._get_hostname()}' |
when combined with the file redirection fails silently
/bin/bash -c "source activate environment && jupyter lab --no-browser --ip=casper-login1 > None/.jupyter_forward/log_2022-03-11T15-36-40.txt 2>&1"We should look into more robust ways to check that jupyter lab is installed and not just jupyter
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working