Skip to content

Commit 94b9977

Browse files
authored
Merge pull request #10 from nats-io/fixed-port-and-nats-server
Fixed port and nats server
2 parents 519836e + 08a9be9 commit 94b9977

File tree

7 files changed

+42
-12
lines changed

7 files changed

+42
-12
lines changed

.github/workflows/pr.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,20 @@ jobs:
88
runs-on: ubuntu-latest
99
env:
1010
BUILD_TYPE: "PR"
11+
nats_server_path: nats-server/main
1112
steps:
1213
- run: echo -e "PR Branch ${{ github.head_ref }}"
1314
- name: Set up JDK 8
1415
uses: actions/setup-java@v2
1516
with:
1617
java-version: '8'
1718
distribution: 'adopt'
19+
- name: Setup GO
20+
uses: actions/setup-go@v2
1821
- name: Check out repository code
1922
uses: actions/checkout@v2
23+
- name: Install Nats Server
24+
run: chmod +x install-nats-server.sh && ./install-nats-server.sh
2025
- name: Build and Test
2126
run: chmod +x gradlew && ./gradlew test
2227
- name: Check Docs

.github/workflows/push_or_merge_to_main.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
BUILD_TYPE: "MERGE"
1212
OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
1313
OSSRH_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
14+
nats_server_path: nats-server/main
1415
steps:
1516
- run: echo -e "PUSH/MERGE to main"
1617
- name: Set up JDK 8
@@ -20,6 +21,12 @@ jobs:
2021
distribution: 'adopt'
2122
- name: Check out repository code
2223
uses: actions/checkout@v2
24+
- name: Setup GO
25+
uses: actions/setup-go@v2
26+
- name: Check out repository code
27+
uses: actions/checkout@v2
28+
- name: Install Nats Server
29+
run: chmod +x install-nats-server.sh && ./install-nats-server.sh
2330
- name: Build and Test
2431
run: chmod +x gradlew && ./gradlew clean test
2532
- name: Publish

.github/workflows/release_main.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,20 @@ jobs:
1515
SIGNING_KEY_ID: ${{ secrets.SIGNING_KEY_ID }}
1616
SIGNING_KEY: ${{ secrets.SIGNING_KEY }}
1717
SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }}
18+
nats_server_path: nats-server/main
1819
steps:
1920
- run: echo -e "RELEASE"
2021
- name: Set up JDK 8
2122
uses: actions/setup-java@v2
2223
with:
2324
java-version: '8'
2425
distribution: 'adopt'
26+
- name: Setup GO
27+
uses: actions/setup-go@v2
2528
- name: Check out repository code
2629
uses: actions/checkout@v2
30+
- name: Install Nats Server
31+
run: chmod +x install-nats-server.sh && ./install-nats-server.sh
2732
- name: Build and Test
2833
run: chmod +x gradlew && ./gradlew clean test
2934
- name: Publish

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ plugins {
88
id 'signing'
99
}
1010

11-
def jarVersion = "1.0.3"
11+
def jarVersion = "1.0.4 "
1212
group = 'io.nats'
1313

1414
def isPr = System.getenv("BUILD_TYPE") == "PR"

install-nats-server.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
git clone https://github.com/nats-io/nats-server.git
2+
cd nats-server
3+
go build main.go
4+
cd ..
5+
nats-server/main -v%

src/main/java/nats/io/NatsServerRunner.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class NatsServerRunner implements AutoCloseable {
2929

3030
private static final Logger LOGGER = Logger.getLogger(NatsServerRunner.class.getName());
3131

32-
private final int port;
32+
private final int _port;
3333

3434
private Process process;
3535
private final String cmdLine;
@@ -232,7 +232,7 @@ public NatsServerRunner(String[] customArgs, int port, boolean debug) throws IOE
232232
* @throws IOException thrown when the server cannot start
233233
*/
234234
public NatsServerRunner(int port, boolean debug, boolean jetstream, String configFilePath, String[] configInserts, String[] customArgs) throws IOException {
235-
this.port = port <= 0 ? nextPort() : port;
235+
_port = port <= 0 ? nextPort() : port;
236236

237237
List<String> cmd = new ArrayList<>();
238238

@@ -260,9 +260,9 @@ public NatsServerRunner(int port, boolean debug, boolean jetstream, String confi
260260
portMatcher.reset(line);
261261

262262
if (portMatcher.find()) {
263-
line = line.replace(portMatcher.group(1), String.valueOf(port));
263+
line = line.replace(portMatcher.group(1), String.valueOf(_port));
264264
cmd.add("--port");
265-
cmd.add(String.valueOf(port));
265+
cmd.add(String.valueOf(_port));
266266
}
267267

268268
writer.write(line);
@@ -292,7 +292,7 @@ public NatsServerRunner(int port, boolean debug, boolean jetstream, String confi
292292
}
293293
} else {
294294
cmd.add("--port");
295-
cmd.add(String.valueOf(port));
295+
cmd.add(String.valueOf(_port));
296296
}
297297

298298
if (jetstream) {
@@ -318,7 +318,7 @@ public NatsServerRunner(int port, boolean debug, boolean jetstream, String confi
318318

319319
process = pb.start();
320320

321-
NatsOutputLogger.logOutput(LOGGER, process, NATS_SERVER, port);
321+
NatsOutputLogger.logOutput(LOGGER, process, NATS_SERVER, _port);
322322

323323
int tries = 10;
324324
// wait at least 1x and maybe 10
@@ -331,7 +331,7 @@ public NatsServerRunner(int port, boolean debug, boolean jetstream, String confi
331331
tries--;
332332
} while (!process.isAlive() && tries > 0);
333333

334-
SocketAddress addr = new InetSocketAddress("localhost", port);
334+
SocketAddress addr = new InetSocketAddress("localhost", _port);
335335
SocketChannel socketChannel = SocketChannel.open();
336336
socketChannel.configureBlocking(true);
337337
boolean scanning = true;
@@ -361,7 +361,7 @@ public NatsServerRunner(int port, boolean debug, boolean jetstream, String confi
361361
* @return the port number
362362
*/
363363
public int getPort() {
364-
return port;
364+
return _port;
365365
}
366366

367367
/**
@@ -370,7 +370,7 @@ public int getPort() {
370370
* @return the uri string
371371
*/
372372
public String getURI() {
373-
return getURIForPort(port);
373+
return getURIForPort(_port);
374374
}
375375

376376
/**

src/test/java/nats/io/NatsServerRunnerTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,18 @@
44
package nats.io;
55

66
import org.junit.jupiter.api.Test;
7-
import static org.junit.jupiter.api.Assertions.*;
7+
8+
import java.io.IOException;
9+
10+
import static org.junit.jupiter.api.Assertions.assertTrue;
811

912
class NatsServerRunnerTest {
13+
1014
@Test
11-
void testSomeLibraryMethod() {
15+
public void testConnection() throws IOException, InterruptedException {
16+
try (NatsServerRunner ts = new NatsServerRunner(false)) {
17+
assertTrue(ts.getPort() > 0);
18+
assertTrue(ts.getURI().startsWith("nats://localhost"));
19+
}
1220
}
1321
}

0 commit comments

Comments
 (0)