[BUG] Crash when opening .m4a files

[Antiwh0re]

Regularly when I tap a file in .m4a format encoded with ALAC codec...

Expected Behavior

...File gets played.

Current Behavior

...App crashes. On re-opening the same file is played successfully.

Steps to Reproduce

Above.

Screenshots

No.

Logs

Some device data in that log, so no.
But after the device part I see many repeats of this pattern:
│ RangeError (length): Invalid value: Not in inclusive range 0..3722: 3723
├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄
│ #0 _Array.[] (dart:core-patch/array.dart)
│ #1 _CastListBase.[] (dart:_internal/cast.dart:99)
│ #2 DEListieSizie.changeListSize (package:dart_extensions/src/list_extensions.dart:394)
│ #3 WaveformController._downscaledWaveformLists. (package:namida/controller/waveform_controller.dart:98)
│ #4 DEListieExt.loop (package:dart_extensions/src/list_extensions.dart:20)
│ #5 WaveformController._downscaledWaveformLists (package:namida/controller/waveform_controller.dart:97)
│ #6 compute. (package:flutter/src/foundation/_isolates_io.dart:19)
│ #7 _RemoteRunner._run (dart:isolate:1090)
│ #8 _RemoteRunner._remoteExecute (dart:isolate:1084)
│ #9 _delayEntrypointInvocation. (dart:isolate-patch/isolate_patch.dart:300)
│ #10 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184)
├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄
│ ⛔ RangeError
I guess it's related to waveform bug we've discussed recently.

Possible Solution

?

[MSOB7YY]

that waveform bug is already fixed, but i dont think that was the problem.
its hard to debug decoder issues crashes, anyways in future i will update ffmpeg decoders so this might help

[Antiwh0re]

I thought of waveform bug because of this WaveformController in the stack trace.
As for the current issue, it seems to me it's not the decoder issue, because it happens only when you'd played some tracks before the .m4a track. If you fresh start a player and then play this file, it plays fine (and continues to play fine for subsequent .m4a tracks). This implies that the bug arises because of the player's inner state, which is different for these two cases.

[MSOB7YY]

decoder issue doesnt mean its always unable to play it, maybe its miscommunication between system and decoders idk, but for sure this issue happened since ffmpeg was added as a fallback decoder. before that videos wouldn't even play

[Antiwh0re]

Fallback decoder? I thought it was the one and only. Which is the main one then?

[MSOB7YY]

the default is system decoders (hardware), or whatever exoplayer uses. this can be equivalent to "hw" in mxplayer for example (not hw+ nor sw)

[Antiwh0re]

So this exoplayer does the actual decoding?

[MSOB7YY]

might or might not. im not so experienced with this