Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Different border radius for miniplayer artwork & Others #383

Open
ninecanine opened this issue Oct 27, 2024 · 2 comments

Comments

@ninecanine
Copy link

ninecanine commented Oct 27, 2024

The best music player I have ever installed.
It has so many customisation options and the control you have over the app is something every app developer should consider. ❤️

Is your feature request related to a problem? Please describe.

When I set border radius multiplier = 100, it makes each and every tile rounded.

Issue 1

•1 Intended setting

Screenshot_2024-10-28-01-38-03-011_com msob7y namida


•2 Even the player settings is rounded which doesn't look good

Screenshot_2024-10-28-01-38-15-014_com msob7y namida


•3 Settings tab got rounded too
Screenshot_2024-10-28-01-38-27-870_com msob7y namida


•4 Tiles in home tab as wells track tile are completely rounded which wasn't intended

Tiles in Home Tab
Screenshot_2024-10-28-01-48-28-739_com msob7y namida

Track tiles
Screenshot_2024-10-28-01-48-08-400_com msob7y namida


However I intended it to round only this page where album tile is round.

Screenshot_2024-10-28-01-38-03-011_com msob7y namida



Issue 2

IMG_20241028_015134

Bottom buttons in track tiles are irregularly aligned and only one button is labled (shuffel). none should be labled or add option either to show lables or not.

(not sure if the irregular alignment of the buttons is on my mobile due to display settings (size = xs) or the problem is with app

Describe the solution you'd like

Border

Specific border settings for every tile if possible because the settings tile looks good when it's sharp squre and the buttons looks good when rounded, album tile looks good rounded as they occupy less space and you can enjoy more floating particles.

YouTube (optional)

Also is it possible to completely remove the youtube player as I use this app specifically for offline music playing and seeing YouTube Tab hurts my eye seriously.

Feature Requests

•1 Lock Screen Music player
I used musicolet aswell for synchronising lyrics manually and I discovered lockscreen music player and it's would be good if you include it in namida too.


•2 Lyrics synchronising
As I said earlier I used musicolet for lyrics synchronisation, if you could add that feature in namida I'll get everything in one app. the way musicolet allows to synchronise music by tapping the line of the lyrics when you hear that line it's just super convenient.

There's lrc-maker repository which allows synchronising lyrics online, but the virtual space button it provides is very small but it works good on pc.


•3 Straight progress bar

IMG_20241028_015320

Add an option to make this progress bar straight line.


•4 Change icons
Is it possible to add option that allows user to change app icon, I really love the icon selected by you but I would like to explore more available options.


Additional context

Add any other context or screenshots about the feature request here.

Apps

•1 Apps/website with lyrics synchronisation feature
Musicolet
lrc-maker

•2 App with lock-screen player
Musicolet



I have requested ton load of features and it's totally fine if they get rejected, I just suggested few features which I would like if they were available and considering the amount of work you have done this app, I already like it a lot it's just best music player.
Thank you ❤️.

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 27, 2024

hey thank u so much!!

the border radius is a simple value where 1.0 is the normal and 0.5 is half of it, etc. setting it to 100 is kinda sus

However I intended it to round only this page where album tile is round.

yah this uuh not really possible, i know customizations is a good thing but i personally dislike this design very much and that would make namida as a whole look kinda cheap


Bottom buttons in track tiles are irregularly aligned and only one button is labled (shuffel). none should be labled or add option either to show lables or not

wdym irregularly aligned? but anyways i did an improvement for this part in beta v4.5.9 so that its more responsive.
the reason why shuffle is the only labeled is just a simple design choice, it looks better this way. u can long press other buttons to know what they do


YouTube (optional)
Also is it possible to completely remove the youtube player as I use this app specifically for offline music playing and seeing YouTube Tab hurts my eye seriously.

settings -> extra -> library tabs 💀💀


1 Lock Screen Music player

this won't be very easy and likely not possible currently

2 Lyrics synchronising

this already is a thing, check the second button on the right and long press to manually choose/search for lyrics. when the lyrics view appears u can tap lines like normal if the lyrics are synced
image

Add an option to make this progress bar straight line.

this has been asked few times before, im still completely against this

4 Change icons

bro thinks its easy to allow that 💀💀 icon choosing process takes as much time as developing, things are not organized like here is play icon here is pause icon, each icon pack has its own set of icons & names. what u asking is me exploring other icon packs, choose equavelent ones and include them as an option..

i appreciate you liking it tho, maybe we can discuss rounded album art if many ppl wanted it, but the others are a no-no hehe
ty so much qt let me know if u got strict opinion on smth here 💗

@ninecanine
Copy link
Author

ninecanine commented Oct 27, 2024

if anything then straight progressive bar and free customisation settings where user can change the corner of tiles of the specific tile instead of changing all at once,

yah this uuh not really possible, i know customizations is a good thing but i personally dislike this design very much and that would make namida as a whole look kinda cheap

if circle is cheap then how about more rounded corners but circle, even then it will affect other tiles too

border radius value = 5

Screenshot_2024-10-28-03-05-46-069_com msob7y namida

Screenshot_2024-10-28-03-05-54-777_com msob7y namida

Screenshot_2024-10-28-03-06-01-407_com msob7y namida


i personally dislike this design very much and that would make namida as a whole look kinda cheap

agreed but what makes namida stand out is this thing, semi-circle background, it actually looks good with circle album, but we all different taste
Screenshot_2024-10-28-03-09-38-744_com miui gallery-edit

this already is a thing, check the second button on the right and long press to manually choose/search for lyrics. when the lyrics view appears u can tap lines like normal if the lyrics are synced

there's already a request about it #222 and the screenshot used in that request if of musicolet app.
I liked this Lyrics feature of namida app a lot in beginning but when I realised that most lyrics are not accurately synced so I decided to sync manually and add it in tag,
anyways I don't mind much about lyrics since there are other apps, I'm hoping you'll consider the other 2 thing

  1. straight progressive bar
  2. about round corners

Thank you again, this was my first GitHub issue.

@MSOB7YY MSOB7YY changed the title [FEATURE REQUEST] [FEATURE REQUEST] Different border radius for miniplayer artwork & Others Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants