Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add playback of APE files #377

Open
Antiwh0re opened this issue Oct 22, 2024 · 15 comments
Open

[FEATURE REQUEST] Add playback of APE files #377

Antiwh0re opened this issue Oct 22, 2024 · 15 comments

Comments

@Antiwh0re
Copy link

Is your feature request related to a problem? Please describe.
I can't play my files in ape (Monkey's audio) format.

Describe the solution you'd like
I'd like the app to properly recognize and play ape files.

Describe alternatives you've considered
None.

Additional context
As you're now using ffmpeg for playback, I assume it's not hard to make Namida play ape files as well. It's a popular lossless audio format, so lack of its support is a missing core function.

Apps
AIMP for Android.

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 26, 2024

can you provide a sample file?

@Antiwh0re
Copy link
Author

What sample file? Audio in APE format?

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 27, 2024

@Antiwh0re yesss

@Antiwh0re
Copy link
Author

Here's a magnet link to a single in APE format:
magnet:?xt=urn:btih:9EB31D7A839F4465D44FAD6480774253ECFCF4E9&tr=http%3A%2F%2Fbt.t-ru.org%2Fann%3Fmagnet&dn=(Electronic%2C%20Oldschool)%20Opus%20III%20-%20It's%20a%20fine%20day%20(single)-%201997%2C%20APE%20(tracks)%2C%20lossless

@Antiwh0re
Copy link
Author

By the way, besides not playing APE files, Namida also doesn't read their tags properly. Now the track number and name of each song is listed in the library as a separate artist.

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 31, 2024

alr i will investigate that

@Antiwh0re
Copy link
Author

It happens to most files, but not all of them. Select few are shown in the library the right way like those I've linked to.

@Antiwh0re
Copy link
Author

So have you tried implementing this feature? And have you thought of adding it to the next release?

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 15, 2024

not yet. its not a feature i can corely work on but im gonna see if its possible to support it by the internal player

@Antiwh0re
Copy link
Author

By internal player you mean ffmpeg? If so, then it's already supported. The developer of another audio player wrote that playing ape files in Android natively (he uses a library exo-something it seems) is a problem because the devs of Android itself haven't programmed it to recognize ape as audio files (unlike flac there's no appropriate mime type for it or something). He also wrote that proprietary players usually bypass this Android defect by calling ffmpeg for every file, which recognizes everything. As you're using ffmpeg now, this implies that you can implement it with little effort.

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 17, 2024

@Antiwh0re exoplayer doesnt support ape format yet
although ffmpeg supports it, it still doesnt play it even while its on "prefer" DefaultRenderersFactory.EXTENSION_RENDERER_MODE_PREFER
not sure what to do exactly except for trying to update ffmpeg extension, but since i can't build it, and the new prebuilt versions are broken, im kind of stuck in between hagahgaha

@Antiwh0re
Copy link
Author

Why don't you ask ffmpeg devs? If the devs of proprietary players manage to bypass this defect, the solution must be out there. For example I've used AIMP for Android some time ago and it was playing APE fine.

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 22, 2024

"ask ffmpeg devs" 💀💀 yah im sure its not so hard if exoplayer or ffmpeg supported that, the thing is i can't edit their code etc to support it, and i dont even know

if there are other open source android players that support it then it might give us hope

@Antiwh0re
Copy link
Author

I'm saying that it does support it, so there must be a way of making it work without rewriting their code (I'm sure the devs of AIMP and others are not doing that). And I'm offering you to ask them (ffmpeg) how to make it work.
As for other open players, I've tried a lot of them and haven't seen one that plays APE. AIMP has closed source.

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 26, 2024

--enable-demuxer=ape --enable-decoder=ape this can be done while building ffmpeg extension for exoplayer, but again i still need to build my own and not use old prebuilt version
i might look into it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants