Add get_sections method
#12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bindgen does not generate bindings for function-like macros. You have to re-implement them by hand in rust.
adds the ability to list all sections in a package
pulsastrix
approved these changes
Nov 30, 2025
Member
pulsastrix
left a comment
pulsastrix
left a comment
There was a problem hiding this comment.
Hi,
thanks for your contributions and sorry for taking a while to review them 😅
All three pull requests look good to me.
thiserror got mistakenly assigned to dev-dependency
and resolve todo
Contributor
Author
|
Nice 👍 I went ahead and resolved the conflicts with the new main on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing to add the
get_sectionsmethod to theUcistruct.I had the following problem: I need to know all sections in a package, but I don't know the names of all the sections.
get_sectionsgives you a list of all section names.In the process of implementing that method, I've also re-implemented some C-macros that bindgen is not able to translate to rust automatically. I've implemented them directly in the libuci-sys crate, as they are (more or less) direct translations of the C macros and don't feel particularly rusty.