Target feature: rdrand / rdrnd

[dhardy]

Isn't this a typo?

rust_rdrand/src/lib.rs

Line 146 in 800e213

if cfg!(target_feature="rdrand") {

$ rustc --print target-features
Available features for this target:
    ...
    rdrnd                         - Support RDRAND instruction.
    rdseed                        - Support RDSEED instruction.

This was also referenced in #5 #6 #9.

[nagisa]

--print target-features probably ends up printing the LLVM names for the features, however rustc has a mapping as seen here which is used to resolve the target_feature cfgs.

[nagisa]

This prints true when compiled with -Ctarget-features="+rdrnd":

fn main() {
    println!("{:?}", cfg!(target_feature="rdrand"));
}

One could argue that the name mismatch between -Ctarget-features and the target_features cfg is not great, but that would be an issue report against rustc either way.