Codex/improve heroku deployment code for n8n qab2dj #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PostgreSQL version to 15 in app.json
Update repository URL in app.json
Update repository URL in app.json
Author
|
u |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| if install_n8n_runtime "$target_version" "$force_install" "$installed_version"; then | ||
| if [ "$force_install" = "true" ]; then | ||
| log "Forced installation completed; unset N8N_FORCE_INSTALL to avoid reinstalling on every boot." | ||
| export N8N_FORCE_INSTALL=false |
There was a problem hiding this comment.
Bug: Heroku Config Var Not Persisting
The export N8N_FORCE_INSTALL=false command only affects the current process, failing to persist across dyno restarts. This means the Heroku config var for N8N_FORCE_INSTALL remains true, leading to n8n being reinstalled on every subsequent dyno boot, contrary to the log message's intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yes