-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown props warning with React 15.2.0 #25
Comments
Can confirm this error. It looks like the props for the |
Have the same error |
+1 |
+1 ( |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
You can use my fork here until this original package gets updated. |
@mzabriskie pull |
@theplatapi that fork works great, thank you! |
@theplatapi Perhaps this is a new issue, I am receiving the following two warnings with your fork: Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead. Warning: DisqusThread: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. This is, obviously, because your code is using React.createclass and React.PropTypes. Should be an easy fix, I can submit a pull request in a bit. I just wanted to check that this was in fact a new issue with later releases of react and not a mistake on my end. Thanks! |
@theplatapi Thanks! I think I got too cocky there, it is turning out to be a bit more complicated than I initially figured. I may put up with the warnings for now. |
@crw @theplatapi I'll have a look at refactoring out the |
https://github.com/theplatapi/react-disqus-thread is now updated! |
The text was updated successfully, but these errors were encountered: