Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown props warning with React 15.2.0 #25

Open
badtant opened this issue Jul 6, 2016 · 18 comments
Open

Unknown props warning with React 15.2.0 #25

badtant opened this issue Jul 6, 2016 · 18 comments

Comments

@badtant
Copy link

badtant commented Jul 6, 2016

Warning: Unknown props `shortname`, `identifier`, `category_id`, `url`, `onNewComment` on <div> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by DisqusThread)
@emilyaviva
Copy link

Can confirm this error. It looks like the props for the ReactDisqusThread are getting copied onto the child <div> and this is creating validation errors.

@kolyasya
Copy link

kolyasya commented Oct 8, 2016

Have the same error

@JimmyLv
Copy link

JimmyLv commented Oct 14, 2016

+1

@sofiia-hlyniana
Copy link

+1 (

@hedgehog34
Copy link

hedgehog34 commented Dec 12, 2016

+1

4 similar comments
@BrunoQuaresma
Copy link

BrunoQuaresma commented Dec 30, 2016

+1

@PascalPixel
Copy link

+1

@juanparadox
Copy link

+1

@ghalex
Copy link

ghalex commented Feb 10, 2017

+1

@theplatapi
Copy link

theplatapi commented Feb 15, 2017

You can use my fork here until this original package gets updated.

@PascalPixel
Copy link

@mzabriskie pull

@a8568730
Copy link

@theplatapi that fork works great, thank you!

@crw
Copy link

crw commented May 31, 2017

@theplatapi Perhaps this is a new issue, I am receiving the following two warnings with your fork:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Warning: DisqusThread: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

This is, obviously, because your code is using React.createclass and React.PropTypes. Should be an easy fix, I can submit a pull request in a bit. I just wanted to check that this was in fact a new issue with later releases of react and not a mistake on my end. Thanks!

@theplatapi
Copy link

@crw Feel free to submit a merge request to my repo.

@crw
Copy link

crw commented May 31, 2017

@theplatapi Thanks! I think I got too cocky there, it is turning out to be a bit more complicated than I initially figured. I may put up with the warnings for now.

@emilyaviva
Copy link

@crw @theplatapi I'll have a look at refactoring out the React.createClass jazz shortly.

@badtant
Copy link
Author

badtant commented Jun 12, 2017

theplatapi#1

@badtant
Copy link
Author

badtant commented Jun 16, 2017

https://github.com/theplatapi/react-disqus-thread is now updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests