Skip to content

Commit 5beb8c8

Browse files
committed
apply a couple of gopls suggestions
1 parent 3480702 commit 5beb8c8

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

check/check.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ type Issue struct {
139139
func (i Issue) Pos() token.Pos { return i.pos }
140140
func (i Issue) Message() string { return i.fname + " - " + i.msg }
141141

142-
// Program supplies Checker with the needed *loader.Program.
142+
// Packages supplies Checker with the loaded packages.
143143
func (c *Checker) Packages(pkgs []*packages.Package) {
144144
c.pkgs = pkgs
145145
}
@@ -388,18 +388,14 @@ func (c *Checker) Check() ([]Issue, error) {
388388
return c.issues, nil
389389
}
390390

391-
func stringsContains(list []string, elem string) bool {
392-
return slices.Contains(list, elem)
393-
}
394-
395391
func (c *Checker) addImplementing(named *types.Named, iface *types.Interface) {
396392
if named == nil || iface == nil {
397393
return
398394
}
399395
list := c.typesImplementing[named]
400396
for method := range iface.Methods() {
401397
name := method.Name()
402-
if !stringsContains(list, name) {
398+
if !slices.Contains(list, name) {
403399
list = append(list, name)
404400
}
405401
}
@@ -481,7 +477,7 @@ func (c *Checker) checkFunc(fn *ssa.Function, pkg *packages.Package) {
481477
}
482478
if recv := fn.Signature.Recv(); recv != nil {
483479
named := findNamed(recv.Type())
484-
if stringsContains(c.typesImplementing[named], fn.Name()) {
480+
if slices.Contains(c.typesImplementing[named], fn.Name()) {
485481
c.debug(" skip - method required to implement an interface\n")
486482
return
487483
}

0 commit comments

Comments
 (0)