Added gcc warnning flags and fix warnings

Author: Martin Vala

Analysis/TAnaInputHandler.cxx

@@ -62,7 +62,7 @@ void TAnaInputHandler::Exec(Option_t *option) {
    // Exec of manager task
    //
 
-   Printf("Running Task %s", GetName());
+   Printf("Running Task %s opt=%s", GetName(),option);
 
 }
 

Analysis/TAnaTaskExample.cxx

@@ -55,6 +55,6 @@ void TAnaTaskExample::Exec(Option_t *option) {
    // Exec of manager task
    //
 
-   Printf("Running Task %s", GetName());
+   Printf("Running Task %s opt=%s", GetName(),option);
 
 }

CMakeLists.txt

@@ -1,6 +1,10 @@
 project(ParallelTasks)
 cmake_minimum_required(VERSION 2.6 FATAL_ERROR)
 
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
+#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic")
+
+
 set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
 find_package(Threads REQUIRED)
 find_package(ROOT REQUIRED)

CutSet/TCutObj.h

@@ -18,7 +18,7 @@ class TCutObj : public TCut {
    TCutObj(const char *name = "cut", const char *title = "Cut Title");
    virtual ~TCutObj();
 
-   virtual Bool_t IsSelected(TObject *obj) { return kTRUE; }
+   virtual Bool_t IsSelected(TObject */*obj*/) { return kTRUE; }
 private:
    ClassDef(TCutObj, 1)
 };

EventAnalysis/TAnaEventInputHandler.cxx

@@ -64,7 +64,7 @@ TAnaEventInputHandler &TAnaEventInputHandler::operator=(const TAnaEventInputHand
 }
 
 //_________________________________________________________________________________________________
-void TAnaEventInputHandler::Exec(Option_t *option) {
+void TAnaEventInputHandler::Exec(Option_t */*option*/) {
    //
    // Exec of manager task
    //

EventAnalysis/TAnaEventTaskExample.cxx

@@ -57,7 +57,7 @@ TAnaEventTaskExample &TAnaEventTaskExample::operator=(const TAnaEventTaskExample
 }
 
 //_________________________________________________________________________________________________
-void TAnaEventTaskExample::Exec(Option_t *option) {
+void TAnaEventTaskExample::Exec(Option_t */*option*/) {
    //
    // Exec of manager task
    //

ParallelTasks/TTaskManager.cxx

@@ -79,7 +79,7 @@ void TTaskManager::Exec(Option_t *option) {
    }
 
    // Loops until not all tasks are assigned
-   Int_t counter = 0;
+//   Int_t counter = 0;
    while (1) {
       TLockGuard lock(&fMutex);
 //      Printf("Manager loop %d", counter++);

ParallelTasks/TTaskMonitorGui.cxx

@@ -135,7 +135,7 @@ void TTaskMonitorGui::ConnectDisconnect() {
       if (fHost.IsNull()) {
          // input box
          char ret[64];
-         TGInputDialog *id = new TGInputDialog(gClient->GetRoot(), this, "Enter hostname", "localhost", ret);
+         TGInputDialog id(gClient->GetRoot(), this, "Enter hostname", "localhost", ret);
          fHost = ret;
       }
 
@@ -231,10 +231,9 @@ void TTaskMonitorGui::DrawMonitorWindow() {
 //_________________________________________________________________________________________________
 void TTaskMonitorGui::WaitFormInfoMessage() {
    TSocket *socket;
-   TMessage *msgCur;
+//   TMessage *msgCur;
    while (1) {
       socket = fSocketMonitor->Select();
-      HandleMessage("");
-
+      if (socket) HandleMessage("");
    }
 }

ParallelTasks/TTaskMonitorMsg.cxx

@@ -28,7 +28,7 @@ void TTaskMonitorMsg::Print(Option_t */*opt*/) const {
       for (j = 0; j < TTaskParallel::kAllStatusTypes; j++) {
          printf(" %d", fNumberOfThreads[i][j]);
       }
-      Printf("");
+      Printf(" ");
    }
 }
 

ParallelTasks/TTaskMonitorServ.cxx

@@ -47,7 +47,7 @@ TTaskMonitorServ::~TTaskMonitorServ() {
 }
 
 //_________________________________________________________________________________________________
-void TTaskMonitorServ::Exec(Option_t *option) {
+void TTaskMonitorServ::Exec(Option_t */*option*/) {
 
    TTaskManager *tm = TTaskManager::GetTaskManager();
    if (tm) {
@@ -132,7 +132,7 @@ void TTaskMonitorServ::StopMonitoring()
 }
 
 //_________________________________________________________________________________________________
-void TTaskMonitorServ::SendMonitoringMsg(Int_t val, Int_t val2)
+void TTaskMonitorServ::SendMonitoringMsg(Int_t /*val*/, Int_t /*val2*/)
 {
 
 

ParallelTasks/TTaskParallel.cxx

@@ -103,7 +103,7 @@ void TTaskParallel::Exec(Option_t *option) {
 }
 
 //_________________________________________________________________________________________________
-void TTaskParallel::RunTask(Option_t *option, TTaskParallel::ETaskType type) {
+void TTaskParallel::RunTask(Option_t *option, TTaskParallel::ETaskType /*type*/) {
 
 
    if (!fTasks) return;

ParallelTasks/TTaskPoolManager.cxx

@@ -40,7 +40,7 @@ void TTaskPoolManager::Init() {
 }
 
 //_________________________________________________________________________________________________
-void TTaskPoolManager::Print(Option_t *option) const {
+void TTaskPoolManager::Print(Option_t */*option*/) const {
 
    Printf("NumberOfThreads = %d", fNumThreads);
 }

ParallelTasks/TTaskThread.cxx

@@ -25,7 +25,7 @@ bool TTaskThread::runTask(TTask *task) {
       msg->IncrementThread(t->GetType(), TTaskParallel::kRunning);
    }
    // executing task
-   t->Exec(TString::Format("%lld", fThreadID).Data());
+   t->Exec(TString::Format("%ld", fThreadID).Data());
 
    {
       TLockGuard lock(&fMutex);

PeacUtils/TPeacVerifierSel.cxx

@@ -42,7 +42,7 @@ void TPeacVerifierSel::SlaveBegin(TTree * /*tree*/)
 
 }
 
-Bool_t TPeacVerifierSel::Process(Long64_t entry)
+Bool_t TPeacVerifierSel::Process(Long64_t /*entry*/)
 {
    if (!fFcIn) return kFALSE;
 

scripts/make.sh

@@ -11,7 +11,7 @@ fi
 cd $PROJECT_DIR/build
 
 if [ ! -f Makefile ];then
-  cmake -DCMAKE_INSTALL_PREFIX="$PROJECT_DIR" ../
+  cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX="$PROJECT_DIR" ../
 fi
 
 CMD="nice -n 15"