Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pentax K-3, K-1 and K-1 Mark II are not recognised. #206

Open
sto3014 opened this issue Feb 1, 2025 · 4 comments
Open

Pentax K-3, K-1 and K-1 Mark II are not recognised. #206

sto3014 opened this issue Feb 1, 2025 · 4 comments

Comments

@sto3014
Copy link
Contributor

sto3014 commented Feb 1, 2025

I fixed this small issue in my fork:

  • Fixed identification for k-3, k-1, k-1 mark ii: see commit sto3014@7d17d16
  • Add focus point file for the pentax k-1 mark ii.txt as a copy of the pentax k-1.txt.

And many thanks for your nice plugin.
Dieter

@capricorn8
Copy link
Collaborator

Perfect! Many thanks, Dieter!

Funny that the plugin doesn't work for these cameras even though they have been listed under "Supported Cameras".
I would have checked and updated support of Pentax cameras only after I finished the "Big 3". Great that you found and fixed this severe issue already now.

Could you please create a pull request for you commit? I will then merge into the main branch so it will be part of the next release.

Karsten

P.S.: Have you come to know about the plugin from the DOCMA blog post?

@sto3014
Copy link
Contributor Author

sto3014 commented Feb 1, 2025

No idea why K-3 and K-1 ever worked. I tested both with pretty new software versions, maybe there were changes.
And right you are, I know about the plugin from DOCMA blog post.

Dieter

@sto3014
Copy link
Contributor Author

sto3014 commented Feb 3, 2025

By the way: The field make in the metadata seems to be correct: RICOH IMAGING COMPANY, LTD.
At least it would match the original condition in the PointsRendererFactory.createRenderer(photo) function. But this condition uses the value ‘make’ returned by photo:getFormattedMetadata( ‘cameraMake’ ).
In short, the problem was probably not caused by an earlier firmware version, but by an earlier Lightroom version.

@capricorn8
Copy link
Collaborator

Thank you, Dieter - this explanation seems to make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants