Skip to content

Commit 52390a2

Browse files
committed
fix(ci): Manual Snap upload to GitHub Releases
- Removed 'snap' from linux.target in electron-builder.yml to prevent implicit Snap Store publishing. - Modified GitHub Actions workflow to explicitly upload the built .snap artifact (along with CLI zip) to GitHub Releases.
1 parent 6c7cf44 commit 52390a2

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

.github/workflows/release.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,13 @@ jobs:
3737
run: pnpm --filter @munlicode/munliwall-core run build
3838

3939
# ------------------------------
40-
# Build & Publish Desktop App
40+
# Build & Publish Desktop App (AppImage and Deb)
4141
# ------------------------------
42-
- name: Build and Publish Desktop App (Linux)
42+
- name: Build and Publish Desktop App (Linux - AppImage, Deb)
4343
env:
4444
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
45+
# Note: We removed 'snap' from linux.target in electron-builder.yml to prevent Snap Store publishing attempts.
46+
# The snap artifact will be built but not published by electron-builder.
4547
run: pnpm --filter @munlicode/munliwall-desktop run release:linux
4648

4749
# ------------------------------
@@ -59,16 +61,17 @@ jobs:
5961
zip -r artifacts/cli.zip packages/cli/dist
6062
6163
# ------------------------------
62-
# Upload CLI Artifacts to Release
64+
# Upload Snap and CLI Artifacts to Release
6365
# ------------------------------
64-
# This step uploads the CLI zip to the release created/managed by electron-builder.
65-
# using softprops/action-gh-release (or similar) or reusing ncipollo but verifying it doesn't overwrite
66-
- name: Upload CLI to Release
66+
- name: Upload Snap and CLI to Release
6767
uses: ncipollo/release-action@v1
6868
with:
6969
tag: ${{ github.ref_name }}
7070
allowUpdates: true
71-
artifacts: artifacts/cli.zip
71+
# electron-builder uploads AppImage and Deb. Add Snap and CLI zip here.
72+
artifacts: |
73+
dist/MunliWall-*-x64.snap # Adjust if artifactName differs
74+
artifacts/cli.zip
7275
token: ${{ secrets.GITHUB_TOKEN }}
7376
omitBodyDuringUpdate: true
7477
omitNameDuringUpdate: true

packages/desktop-app/electron-builder.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ executableName: munliwall
2626
linux:
2727
target:
2828
- AppImage
29-
- snap
3029
- deb
3130
maintainer: Nurzhan Murakhan <nurzhanmuratkhan@gmail.com>
3231
synopsis: Desktop Wallpaper Application Suite

0 commit comments

Comments
 (0)