Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOS name insconsistencies #2

Open
davidcc73 opened this issue Oct 22, 2024 · 0 comments
Open

TOS name insconsistencies #2

davidcc73 opened this issue Oct 22, 2024 · 0 comments

Comments

@davidcc73
Copy link

I already fixed those at my fork: https://github.com/davidcc73/P4-SFC

but the project is already too different to merge, the changes were:

For the P4 code and its .json files with table entries, TOS was just the 6 LMS bits of TOS, which is DSCP, while the remaining 2 bits were correctly assigned as ECN. So in the P4 code, the TOS field was changed to what the field actually is, the DSCP field.

For Python, the send.py demanded a TOS value to use in the packets, and by doing that, it manipulated the DSCP, but the ECN filed too, which is used to do congestion control at run time, so it was changed to ask for just for the DSCP value, and only inject that part in the created packet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant