Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui][Menu] Selection is lost in context menu Demo (Safari only) #43997

Open
1 task done
ebengtso opened this issue Oct 4, 2024 · 3 comments · May be fixed by #44903
Open
1 task done

[docs][material-ui][Menu] Selection is lost in context menu Demo (Safari only) #43997

ebengtso opened this issue Oct 4, 2024 · 3 comments · May be fixed by #44903
Assignees
@DiegoAndai
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@ebengtso
Copy link

ebengtso commented Oct 4, 2024 •
edited
Loading

Search keywords

Safari Lose Focus after Menu

Latest version

  • I have tested the latest version

Steps to reproduce

Link to live example:

mui

To reproduce, use the example. You need to select some text in the example before triggering the menu.

Steps:

  1. Open mui Menu documentation page
  2. Refer to the context menu sample in the page
  3. Select a range of text
  4. right click to display menu
  5. chose a menu option
  6. Bug is reproduced: The selection is lost.

Bug can only be reproduced in safari, and not in chrome

Current behavior

Focus, and selection, is lost after menu is closed

Expected behavior

The text selection should not be lost after the menu closes

Screenshot from Chrome
Image

Context

Mui documentation example gives the context

Your environment
@ebengtso ebengtso added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 4, 2024
@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label Oct 7, 2024
@DiegoAndai
Copy link
Member

Thanks for the report @ebengtso! I can confirm the issue:

Safari

Screen.Recording.2024-10-08.at.16.17.21.mov

Chrome

Screen.Recording.2024-10-08.at.16.18.01.mov

I can also confirm this is present in v6 and v5.

Accepting as a bug and adding the ready-to-take label.

@DiegoAndai DiegoAndai added bug 🐛 Something doesn't work ready to take Help wanted. Guidance available. There is a high chance the change will be accepted component: menu This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: text field This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Oct 8, 2024
@DiegoAndai DiegoAndai changed the title Selection on text field is lost after Menu: Safari only issue [docs][material-ui][Menu] Selection is lost in context menu Demo (Safari only) Oct 8, 2024
@DiegoAndai DiegoAndai added the package: material-ui Specific to @mui/material label Oct 8, 2024
@NooBat
Copy link

NooBat commented Oct 26, 2024

Hi @DiegoAndai, can I pick this up? I came up with a workaround for this

@DiegoAndai
Copy link
Member

@NooBat sorry for the delay.

Sure 😊, go ahead. Let me know if you need any help. Thanks in advance.

@NooBat NooBat linked a pull request Dec 30, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoAndai DiegoAndai

Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Fix Context Menu selection lost on Safari NooBat/material-ui
4 participants
@ebengtso @DiegoAndai @NooBat @zannager