changed back testing

Author: mtelek

.github/workflows/build.yml

@@ -7,98 +7,32 @@ on:
     branches: [ "main" ]
 
 jobs:
-  test:
+  build:
     runs-on: ubuntu-latest
     env:
       CI: "true"
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
 
       - name: Install dependencies
         run: |
           sudo apt-get update
-          sudo apt-get install -y make gcc libreadline-dev valgrind expect
-
+          sudo apt-get install -y make gcc libreadline-dev
+          
       - name: Build project
         run: |
           make re
-          [ -f "minishell" ] || (echo "Build failed" && exit 1)
-
-      - name: Basic command tests
-        run: |
-          # Test echo
-          echo 'echo hello' | ./minishell | grep -q "hello" || (echo "FAIL: echo" && exit 1)
-          
-          # Test pwd
-          echo 'pwd' | ./minishell | grep -q $(pwd) || (echo "FAIL: pwd" && exit 1)
           
-          # Test env
-          echo 'env' | ./minishell | grep -q "PATH=" || (echo "FAIL: env" && exit 1)
-          
-          # Test cd (using expect for interactive testing)
-          echo 'spawn ./minishell
-                send "cd ..\r"
-                send "pwd\r"
-                expect {
-                  "$(dirname $(pwd))" { exit 0 }
-                  timeout { exit 1 }
-                }' > test_cd.exp
-          expect test_cd.exp || (echo "FAIL: cd" && exit 1)
-
-      - name: Pipe and redirection tests
+      - name: Run basic tests
         run: |
-          # Test pipes
-          echo 'ls | head -n 3 | wc -l' | ./minishell | grep -q "3" || (echo "FAIL: pipes" && exit 1)
+          ./minishell <<< "echo hello" | grep -q "hello"
+          ./minishell <<< "pwd" | grep -q $(pwd)
           
-          # Test output redirection
-          echo 'echo test > testfile && cat testfile' | ./minishell | grep -q "test" || (echo "FAIL: output redirection" && exit 1)
-          
-          # Test input redirection
-          echo 'cat < Makefile | grep minishell' | ./minishell | grep -q "minishell" || (echo "FAIL: input redirection" && exit 1)
-          rm -f testfile
-
-      - name: Error handling tests
+      - name: Check for memory leaks (valgrind)
+        if: ${{ !cancelled() }}
         run: |
-          # Test invalid commands
-          echo 'invalidcmd' | ./minishell 2>&1 | grep -q "command not found" || (echo "FAIL: invalid command" && exit 1)
-          
-          # Test syntax errors
-          echo 'echo |' | ./minishell 2>&1 | grep -q "syntax error" || (echo "FAIL: pipe syntax" && exit 1)
-          echo 'echo >' | ./minishell 2>&1 | grep -q "syntax error" || (echo "FAIL: redirection syntax" && exit 1)
-
-      - name: Builtin tests
-        run: |
-          # Test export
-          echo 'export TEST_VAR=123 && env' | ./minishell | grep -q "TEST_VAR=123" || (echo "FAIL: export" && exit 1)
-          
-          # Test unset
-          echo 'export TEST_VAR=123 && unset TEST_VAR && env' | ./minishell | grep -qv "TEST_VAR" || (echo "FAIL: unset" && exit 1)
-          
-          # Test exit
-          echo 'exit 42' | ./minishell
-          [ $? -eq 42 ] || (echo "FAIL: exit code" && exit 1)
-
-      - name: Memory leak tests
-        run: |
-          mkdir -p logs
-          # Test simple command
-          echo 'echo hello' | valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
-            --log-file=logs/valgrind_simple.log ./minishell
-            
-          # Test pipe command
-          echo 'ls | head -n 3' | valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
-            --log-file=logs/valgrind_pipe.log ./minishell
-            
-          # Check for leaks
-          ! grep -q "definitely lost" logs/valgrind_*.log || (echo "Memory leaks detected" && exit 1)
-
-      - name: Upload test results
-        if: always()
-        uses: actions/upload-artifact@v4
-        with:
-          name: test-results
-          path: logs/
-          retention-days: 1
-          
+          sudo apt-get install -y valgrind
+          valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
+          --error-exitcode=1 ./minishell <<< "exit"