feat: Rewrite to a Nitro Module (#862)

* feat: Create `packages/react-native-mmkv` nitro module

* Add Example

* Remove current `package/`

* feat: Add monorepo

* feat: Nitrogen specs

* Add files

* Set up MMKV

* fix

* fix: Rename to build

* feat: Add spec implementations

* fix: Public include

* Set up example

* Add iOS

* This is what you need to your app to make it build??

* Implement MMKV

* fix: Fix cannot default-construct HybridObject error

* gitignore

* Path theoretically cannot be empty

* Expose default ID natively

* It finally inits!

* chore: Clang format

* Pattern-match types in variant

* feat: Add memory warning and web mock instances

* Use mock instance

* feat: Implement `addOnValueChangedListener` natively

* chore: Format C++

* Clang format

* Update format

* Update .clang-format

* Notify on value changed

* fix: Update GitHub actions

* Add jest

* fix: Add build:android-release script

* chore: Add github formatter

* fix: Use namespace here..? why? idk

* feat: Implement Android platform context

* Delete .bundle

* feat: Add back hooks

* Add back hooks test

* Add hooks to example again

* Update App.test.tsx

* fix: Only build 64-bit in example

* fix: Update gemfile order? idk

* fix: Fix wrong CI names

* fix: Use hermesc from root node_modules

Author: mrousavy

package/.clang-format renamed to .clang-format

@@ -2,14 +2,14 @@
 
 # Standard
 BasedOnStyle: llvm
-Standard: c++14
+Standard: c++20
 
 # Indentation
 IndentWidth: 2
-ColumnLimit: 100
+ColumnLimit: 140
 
 # Includes
-SortIncludes: true
+SortIncludes: CaseSensitive
 SortUsingDeclarations: true
 
 # Pointer and reference alignment
@@ -20,7 +20,7 @@ ReflowComments: true
 # Line breaking options
 BreakBeforeBraces: Attach
 BreakConstructorInitializers: BeforeColon
+AlwaysBreakTemplateDeclarations: true
 AllowShortFunctionsOnASingleLine: Empty
 IndentCaseLabels: true
 NamespaceIndentation: Inner
-

.github/workflows/build-android-release.yml

@@ -13,22 +13,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
+      - uses: oven-sh/setup-bun@v2
 
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-      - name: Restore node_modules from cache
-        uses: actions/cache@v4
-        id: yarn-cache
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-      - name: Install node_modules
-        run: yarn install --frozen-lockfile --cwd package
-      - name: Install node_modules for example/
-        run: yarn install --frozen-lockfile --cwd package/example
+      - name: Install npm dependencies (bun)
+        run: bun install
+      - name: Install npm dependencies in example/ (bun)
+        working-directory: example
+        run: bun install
 
       - name: Setup JDK 17
         uses: actions/setup-java@v4
@@ -38,29 +29,20 @@ jobs:
           java-package: jdk
 
       - name: Run Gradle Build for example/android/
-        working-directory: package/example
-        run: yarn build:android-release
+        working-directory: example
+        run: bun run build:android-release
 
-      - name: Upload arm64 APK to Release
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ github.event.release.upload_url }}
-          asset_path: package/example/android/app/build/outputs/apk/release/app-arm64-v8a-release.apk
-          asset_name: "MMKVExample-${{ github.event.release.tag_name }}-arm64-v8a.apk"
-          asset_content_type: application/vnd.android.package-archive
-      - name: Upload x86_64 APK to Release
+      - name: Upload APK to Release
         uses: actions/upload-release-asset@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ github.event.release.upload_url }}
-          asset_path: package/example/android/app/build/outputs/apk/release/app-x86_64-release.apk
-          asset_name: "MMKVExample-${{ github.event.release.tag_name }}-x86_64.apk"
+          asset_path: example/android/app/build/outputs/apk/release/app-release.apk
+          asset_name: "MmkvExample-${{ github.event.release.tag_name }}.apk"
           asset_content_type: application/vnd.android.package-archive
 
       # Gradle cache doesn't like daemons
       - name: Stop Gradle Daemon
-        working-directory: package/example/android
+        working-directory: example/android
         run: ./gradlew --stop

.github/workflows/build-android.yml

@@ -6,31 +6,44 @@ on:
       - main
     paths:
       - '.github/workflows/build-android.yml'
-      - 'package/android/**'
-      - 'package/cpp/**'
-      - 'package/MMKV/**'
-      - 'package/yarn.lock'
-      - 'package/example/android/**'
-      - 'package/example/yarn.lock'
+      - 'example/android/**'
+      - '**/nitrogen/generated/shared/**'
+      - '**/nitrogen/generated/android/**'
+      - 'packages/react-native-nitro-test/cpp/**'
+      - 'packages/react-native-nitro-test/android/**'
+      - 'packages/react-native-nitro-test-external/cpp/**'
+      - 'packages/react-native-nitro-test-external/android/**'
+      - 'packages/react-native-nitro-modules/cpp/**'
+      - 'packages/react-native-nitro-modules/android/**'
+      - '**/bun.lock'
+      - '**/react-native.config.js'
+      - '**/nitro.json'
   pull_request:
     paths:
       - '.github/workflows/build-android.yml'
-      - 'package/android/**'
-      - 'package/cpp/**'
-      - 'package/MMKV/**'
-      - 'package/yarn.lock'
-      - 'package/example/android/**'
-      - 'package/example/yarn.lock'
+      - 'example/android/**'
+      - '**/nitrogen/generated/shared/**'
+      - '**/nitrogen/generated/android/**'
+      - 'packages/react-native-nitro-test/cpp/**'
+      - 'packages/react-native-nitro-test/android/**'
+      - 'packages/react-native-nitro-test-external/cpp/**'
+      - 'packages/react-native-nitro-test-external/android/**'
+      - 'packages/react-native-nitro-modules/cpp/**'
+      - 'packages/react-native-nitro-modules/android/**'
+      - '**/bun.lock'
+      - '**/react-native.config.js'
+      - '**/nitro.json'
 
 jobs:
-  build_example:
-    name: Build Android Example App
+  build_new:
+    name: Build Android Example App (new architecture)
     runs-on: ubuntu-latest
-    defaults:
-      run:
-        working-directory: package/
     steps:
       - uses: actions/checkout@v5
+      - uses: oven-sh/setup-bun@v2
+
+      - name: Install npm dependencies (bun)
+        run: bun install
 
       - name: Setup JDK 17
         uses: actions/setup-java@v4
@@ -39,30 +52,57 @@ jobs:
           java-version: 17
           java-package: jdk
 
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-      - name: Restore node_modules from cache
+      - name: Restore Gradle cache
         uses: actions/cache@v4
-        id: yarn-cache
         with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          path: |
+            ~/.gradle/caches
+          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
           restore-keys: |
-            ${{ runner.os }}-yarn-
-      - name: Install node_modules
-        run: yarn install --frozen-lockfile
-      - name: Install node_modules for example/
-        run: yarn install --frozen-lockfile --cwd example
+            ${{ runner.os }}-gradle-
+      - name: Run Gradle Build for example/android/
+        working-directory: example/android
+        run: ./gradlew assembleDebug --no-daemon --build-cache
+
+      # Gradle cache doesn't like daemons
+      - name: Stop Gradle Daemon
+        working-directory: example/android
+        run: ./gradlew --stop
+
+  build_old:
+    name: Build Android Example App (old architecture)
+    needs: build_new
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+      - uses: oven-sh/setup-bun@v2
+
+      - name: Install npm dependencies (bun)
+        run: bun install
+
+      - name: Disable new architecture in gradle.properties
+        run: sed -i "s/newArchEnabled=true/newArchEnabled=false/g" example/android/gradle.properties
+
+      - name: Setup JDK 17
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'zulu'
+          java-version: 17
+          java-package: jdk
 
       - name: Restore Gradle cache
         uses: actions/cache@v4
         with:
           path: |
             ~/.gradle/caches
-            ~/.gradle/wrapper
           key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
           restore-keys: |
             ${{ runner.os }}-gradle-
       - name: Run Gradle Build for example/android/
-        run: cd example/android && ./gradlew assembleDebug --build-cache && cd ../..
+        working-directory: example/android
+        run: ./gradlew assembleDebug --no-daemon --build-cache
+
+      # Gradle cache doesn't like daemons
+      - name: Stop Gradle Daemon
+        working-directory: example/android
+        run: ./gradlew --stop

.github/workflows/build-ios-release.yml

@@ -13,29 +13,20 @@ jobs:
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v5
+      - uses: oven-sh/setup-bun@v2
 
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-      - name: Restore node_modules from cache
-        uses: actions/cache@v4
-        id: yarn-cache
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-      - name: Install node_modules
-        run: yarn install --frozen-lockfile --cwd package
-      - name: Install node_modules for example/
-        run: yarn install --frozen-lockfile --cwd package/example
+      - name: Install npm dependencies (bun)
+        run: bun install
+      - name: Install npm dependencies in example/ (bun)
+        working-directory: example
+        run: bun install
 
       - name: Setup Ruby (bundle)
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: 2.7.2
           bundler-cache: true
-          working-directory: package/example
+          working-directory: example
 
       - name: Select Xcode 16.4
         run: sudo xcode-select -s "/Applications/Xcode_16.4.app/Contents/Developer"
@@ -48,11 +39,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-pods-
       - name: Install Pods
-        working-directory: package/example
-        run: yarn pods
+        working-directory: example
+        run: bun pods
 
       - name: Build App (Release, Simulator)
-        working-directory: package/example/ios
+        working-directory: example/ios
         run: |
           set -o pipefail
           xcodebuild \
@@ -68,15 +59,15 @@ jobs:
 
       - name: Package .app for Simulator
         run: |
-          cd package/example/ios/build/Build/Products/Release-iphonesimulator
-          zip -r ../../../../../../../MmkvExample-Release-Simulator.zip MMKVExample.app
+          cd example/ios/build/Build/Products/Release-iphonesimulator
+          zip -r ../../../../../../MmkvExample-Release-Simulator.zip MmkvExample.app
 
       - name: Upload .app to Release
         uses: actions/upload-release-asset@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ github.event.release.upload_url }}
-          asset_path: MMKVExample-Release-Simulator.zip
-          asset_name: "MMKVExample-Simulator-${{ github.event.release.tag_name }}.app.zip"
+          asset_path: MmkvExample-Release-Simulator.zip
+          asset_name: "MmkvExample-Simulator-${{ github.event.release.tag_name }}.app.zip"
           asset_content_type: application/zip