Commit b961c8e
committed
Revert "ytdl_hook: add chapters by parsing video's description"
This reverts commit e9c4325.
yt-dlp implemented its own parsing to extract chapters from the
descriptions in videos without chapter markers in the player over 3
years ago in yt-dlp/yt-dlp@0fe51254 (the PR is
even inspired by mpv). Actually it was present even earlier in
youtube-dl but was removed for unknown reasons in
ytdl-org/youtube-dl@67299f2.
So we can remove our parsing code.
A sample video without chapter markers is
https://www.youtube.com/watch?v=PoFkd42WvQA (because the chapters don't
start at 0:00?) - you can test that mpv still shows chapters after this
commit. Actually both mpv and yt-dlp seem to only extract 8 chapters
from this description for some reason, so neither was working perfectly
anyway. And it seems that such videos without chapter markers are rare
by now anyway - we can't find any other.
Our parsing was actually worse than yt-dlp's, because #16085 added an
option to disable it to fix the misdetection reported in #16081, but
yt-dlp correctly returns no chapter for that video
(https://www.youtube.com/watch?v=1v_4dL8l8pQ).1 parent 5253108 commit b961c8e
1 file changed
+0
-31
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | 253 | | |
283 | 254 | | |
284 | 255 | | |
| |||
829 | 800 | | |
830 | 801 | | |
831 | 802 | | |
832 | | - | |
833 | | - | |
834 | 803 | | |
835 | 804 | | |
836 | 805 | | |
| |||
0 commit comments