mp_image: keep chroma location consistent for non-subsampled formats

Could also be set to unknown, but let's keep it center, so any fallbacks
in other places wouldn't trigger. In practice it shouldn't be used for
non-subsampled formats.

Author: kasper93

video/img_format.c

@@ -824,6 +824,12 @@ int mp_imgfmt_select_best_list(int *dst, int num_dst, int src)
     return best;
 }
 
+bool mp_imgfmt_is_subsampled(enum mp_imgfmt fmt)
+{
+    struct mp_imgfmt_desc desc = mp_imgfmt_get_desc(fmt);
+    return desc.chroma_xs || desc.chroma_ys;
+}
+
 bool mp_imgfmt_is_420_subsampled(enum mp_imgfmt fmt)
 {
     struct mp_imgfmt_desc desc = mp_imgfmt_get_desc(fmt);

video/img_format.h

@@ -336,6 +336,7 @@ char **mp_imgfmt_name_list(void);
 
 int mp_imgfmt_select_best(int dst1, int dst2, int src);
 int mp_imgfmt_select_best_list(int *dst, int num_dst, int src);
+bool mp_imgfmt_is_subsampled(enum mp_imgfmt fmt);
 bool mp_imgfmt_is_420_subsampled(enum mp_imgfmt fmt);
 
 #endif /* MPLAYER_IMG_FORMAT_H */

video/mp_image.c

@@ -1032,11 +1032,16 @@ void mp_image_params_guess_csp(struct mp_image_params *params)
         params->color.hdr = pl_hdr_metadata_empty;
     }
 
-    if (params->chroma_location == PL_CHROMA_UNKNOWN) {
-        if (params->repr.levels == PL_COLOR_LEVELS_LIMITED)
-            params->chroma_location = PL_CHROMA_LEFT;
-        if (params->repr.levels == PL_COLOR_LEVELS_FULL)
-            params->chroma_location = PL_CHROMA_CENTER;
+    if (mp_imgfmt_is_subsampled(params->hw_subfmt ? params->hw_subfmt : params->imgfmt)) {
+        if (params->chroma_location == PL_CHROMA_UNKNOWN) {
+            if (params->repr.levels == PL_COLOR_LEVELS_LIMITED)
+                params->chroma_location = PL_CHROMA_LEFT;
+            if (params->repr.levels == PL_COLOR_LEVELS_FULL)
+                params->chroma_location = PL_CHROMA_CENTER;
+        }
+    } else {
+        // Set to center for non-subsampled formats.
+        params->chroma_location = PL_CHROMA_CENTER;
     }
 
     if (params->light == MP_CSP_LIGHT_AUTO) {