Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdav1d #239

Open
truexfan81 opened this issue Nov 11, 2024 · 6 comments
Open

libdav1d #239

truexfan81 opened this issue Nov 11, 2024 · 6 comments

Comments

@truexfan81
Copy link

please add --enable-libdav1d to scripts/ffmpeg-config

thank you

@sfan5
Copy link
Member

sfan5 commented Nov 11, 2024

You can easily do this yourself as described in the README.

@truexfan81
Copy link
Author

You can easily do this yourself as described in the README.

Yes i did that on my current build environment, the problem is remembering to do it in the future. I was not even aware it was required until yesterday when i gave my build of mpv a youtube link that was in AV1 and it wouldn't play it. To prevent a repeat of that for myself and others i sent a pull request with it added to the script.

@sfan5
Copy link
Member

sfan5 commented Nov 26, 2024

I think a good solution would be to enable dav1d by default if it's installed like scripts/ffmpeg-config does for either gnutls or openssl.

@kasper93
Copy link
Contributor

I think a good solution would be to enable dav1d by default if it's installed like scripts/ffmpeg-config does for either gnutls or openssl.

It's possible, but in this case where do we stop?

@sfan5
Copy link
Member

sfan5 commented Nov 26, 2024

The general principle of mpv-build seems to be that the user should enable what he needs, hence my first reply.
But AV1 support is arguably a core feature to expect from a video player, so it makes sense to auto-detect.

@kasper93
Copy link
Contributor

But AV1 support is arguably a core feature to expect from a video player, so it makes sense to auto-detect.

Indeed. I would expect ffmpeg to actually provide it by default (autodetect), but it has to be explicitly enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants