Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high volume notes. #34

Open
ghost opened this issue Mar 17, 2024 · 1 comment
Open

Fix high volume notes. #34

ghost opened this issue Mar 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Mar 17, 2024

Whenever you type in MPP.press(...), and make the volume greater than 100 in the console. The site will allow you to play an impossible note that exceeds the regular limit of volume, and maybe break your speakers if you set it really high.

@lithiumjs
Copy link
Contributor

The server already filters notes with invalid velocity (should be between 0 and 1), so it's client-side only. I don't think I'd consider that an issue, since you can't do that in the frontend without accessing the console or using userscripts. Shouldn't be that hard to fix, though — just clamp the velocity in MPP.press.

@fucksophie fucksophie added the enhancement New feature or request label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants