Reduce number of exported functions

Author: dpavlotzky

decode.go

@@ -69,7 +69,7 @@ type Domain struct {
 
 // Convert rawbody to XML and subtract the 'body' from the
 // SOAP-envelope into the struct given with out
-func Decode(rawbody []byte, out interface{}) error {
+func decode(rawbody []byte, out interface{}) error {
 	dec := xml.NewDecoder(bytes.NewReader(rawbody))
 
 	for {

domainservice.go

@@ -14,20 +14,20 @@ type DomainService struct {
 }
 
 func (c *DomainService) DomainNames() ([]string, error) {
-	rawbody, e := Lookup(c.Creds, Request{Service: domainService, Method: "getDomainNames", Body: `<ns1:getDomainNames/>`})
+	rawbody, e := lookup(c.Creds, request{Service: domainService, Method: "getDomainNames", Body: `<ns1:getDomainNames/>`})
 	if e != nil {
 		return nil, e
 	}
 
 	domains := &DomainNames{}
-	e = Decode(rawbody, &domains)
+	e = decode(rawbody, &domains)
 	return domains.Item, e
 }
 
 func (c *DomainService) Domain(name string) (*Domain, error) {
-	rawbody, e := Lookup(c.Creds, Request{
+	rawbody, e := lookup(c.Creds, request{
 		Service: domainService,
-		ExtraParams: []KV{
+		ExtraParams: []kV{
 			{Key: "0", Value: name},
 		},
 		Method: "getInfo",
@@ -38,23 +38,23 @@ func (c *DomainService) Domain(name string) (*Domain, error) {
 	}
 
 	domain := &Domain{}
-	e = Decode(rawbody, &domain)
+	e = decode(rawbody, &domain)
 	return domain, e
 }
 
 func (c *DomainService) Domains(names []string) ([]Domain, error) {
 	entryTemplate := `<item xsi:type="xsd:string">%s</item>`
-	params := []KV{}
+	params := []kV{}
 	xml := ``
 
 	for idx, v := range names {
 		xml = xml + fmt.Sprintf(entryTemplate, v)
-		params = append(params, []KV{
+		params = append(params, []kV{
 			{Key: fmt.Sprintf("0[%d]", idx), Value: v},
 		}...)
 	}
 
-	rawbody, e := Lookup(c.Creds, Request{
+	rawbody, e := lookup(c.Creds, request{
 		Service:     domainService,
 		ExtraParams: params,
 		Method:      "batchGetInfo",
@@ -65,29 +65,29 @@ func (c *DomainService) Domains(names []string) ([]Domain, error) {
 	}
 
 	domains := &Domains{}
-	e = Decode(rawbody, &domains)
+	e = decode(rawbody, &domains)
 	return domains.Domains, e
 }
 
 func (c *DomainService) SetDNSEntries(domain string, entries []DomainDNSentry) error {
 	entryTemplate := `<item xsi:type="ns1:DnsEntry"><name xsi:type="xsd:string">%s</name><expire xsi:type="xsd:int">%d</expire><type xsi:type="xsd:string">%s</type><content xsi:type="xsd:string">%s</content></item>`
 
-	params := []KV{
+	params := []kV{
 		{Key: "0", Value: domain},
 	}
 	xml := ``
 
 	for idx, entry := range entries {
 		xml = xml + fmt.Sprintf(entryTemplate, entry.Name, entry.Expire, entry.Type, entry.Content)
-		params = append(params, []KV{
+		params = append(params, []kV{
 			{fmt.Sprintf("1[%d][name]", idx), entry.Name},
 			{fmt.Sprintf("1[%d][expire]", idx), strconv.Itoa(entry.Expire)},
 			{fmt.Sprintf("1[%d][type]", idx), entry.Type},
 			{fmt.Sprintf("1[%d][content]", idx), entry.Content},
 		}...)
 	}
 
-	rawbody, e := Lookup(c.Creds, Request{
+	rawbody, e := lookup(c.Creds, request{
 		Service:     domainService,
 		ExtraParams: params,
 		Method:      "setDnsEntries",

signature.go

@@ -28,7 +28,7 @@ func sha512ASN1(data []byte) []byte {
 	return append(asn1, h.Sum(nil)...)
 }
 
-func Sign(privKey *rsa.PrivateKey, params []KV) (string, error) {
+func sign(privKey *rsa.PrivateKey, params []kV) (string, error) {
 	asn1 := sha512ASN1(urlencode(params))
 
 	sig, e := rsa.SignPKCS1v15(nil, privKey, crypto.Hash(0), asn1)

signature_test.go

@@ -10,12 +10,12 @@ import (
 )
 
 func TestParamEncode(t *testing.T) {
-	in := []KV{
-		KV{"__method", "getDomainNames"},
-		KV{"__service", "DomainService"},
-		KV{"__hostname", "api.transip.nl"},
-		KV{"__timestamp", "1492760973"},
-		KV{"__nonce", "58f9b98ddd3999.86051758"},
+	in := []kV{
+		kV{"__method", "getDomainNames"},
+		kV{"__service", "DomainService"},
+		kV{"__hostname", "api.transip.nl"},
+		kV{"__timestamp", "1492760973"},
+		kV{"__nonce", "58f9b98ddd3999.86051758"},
 	}
 	expect := []byte(`__method=getDomainNames&__service=DomainService&__hostname=api.transip.nl&__timestamp=1492760973&__nonce=58f9b98ddd3999.86051758`)
 

soap.go

@@ -28,14 +28,14 @@ func uniqid() string {
 	)
 }
 
-type Request struct {
+type request struct {
 	Service     string         // Service to call on TransIP side
-	ExtraParams []KV // Additional params for the signature-code
+	ExtraParams []kV // Additional params for the signature-code
 	Body        string         // XML body to send in envelope
 	Method      string         // Method to call on service
 }
 
-func Lookup(c Client, in Request) ([]byte, error) {
+func lookup(c Client, in request) ([]byte, error) {
 	raw := fmt.Sprintf(`<?xml version="1.0" encoding="UTF-8"?>
 <SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/"
 	xmlns:ns1="%s" xmlns:xsd="http://www.w3.org/2001/XMLSchema"
@@ -83,14 +83,14 @@ func Lookup(c Client, in Request) ([]byte, error) {
 	})
 
 	kv := in.ExtraParams
-	kv = append(kv, []KV{
+	kv = append(kv, []kV{
 		{"__method", in.Method},
 		{"__service", in.Service},
 		{"__hostname", API_URL},
 		{"__timestamp", now},
 		{"__nonce", nonce}}...,
 	)
-	sig, e := Sign(c.PrivateKey, kv)
+	sig, e := sign(c.PrivateKey, kv)
 	if e != nil {
 		return []byte{}, e
 	}

urlencode.go

@@ -6,15 +6,15 @@ import (
 	"strings"
 )
 
-type KV struct {
+type kV struct {
 	Key   string
 	Value string
 }
 
 // Encode encodes the values into ``URL encoded'' form
 // ("bar=baz&foo=quux") NOT sorted.
 // https://golang.org/src/net/url/url.go?s=24497:24528#L850
-func urlencode(v []KV) []byte {
+func urlencode(v []kV) []byte {
 	if v == nil {
 		return []byte{}
 	}