Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: promoted add-ons and resolving them with override decisions -> override a policy that disables content with another one #15330

Open
1 task done
ioanarusiczki opened this issue Feb 3, 2025 · 1 comment

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Feb 3, 2025

What happened?

Case is: override : a policy that disabled content overridden with another policy that disabled

  1. A report for a promoted add-on goes to Cinder
  2. Decision is to disable it with Content, specifically Spam
  3. From Cinder it's overridden with Acceptable Use, specifically Controlled substances
  4. At this point no emails sent to reporter or developer

What did you expect to happen?

There's 2 reports in 2nd level approval queue from rev tools
https://reviewers.addons-dev.allizom.org/en-US/reviewers/decision-review/6633
https://reviewers.addons-dev.allizom.org/en-US/reviewers/decision-review/6634

Also noticed that the second decision 6634 had 3 available options (proceed, approve and forward to rev tools) while 6633 had 2 available options (proceed and approve).

Further I tried to resolve 6633 with proceed -> now emails were sent , to the developer the first policy is displayed Content, specifically Spam

-> I am not sure if any of this is supposed to work but in case it should then 6633 should be canceled somehow.

Going back on the page https://reviewers.addons-dev.allizom.org/en-US/reviewers/decision-review/6633 the process button is greyed out so maybe that should happen a bit earlier.

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants