Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: server error at unreject+reject when a developer appeal is attached with a promoted add-on #15322

Open
1 task done
ioanarusiczki opened this issue Jan 31, 2025 · 4 comments

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Jan 31, 2025

Followup #15306

What happened?

STR:

tested with https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635753

  1. an abuse report is sent for a version , report flags it for HR
  2. version is rejected + the report checked
  3. it goes into the 2nd level approval queue because it's in a promoted group
  4. decision is to proceed
  5. emails are sent and content is rejected
  6. developer is sending the appeal
  7. version is flagged for HR again and present in the Manual Review queue
  8. unreject + reject and attach the appeal to it

What did you expect to happen?

Image

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@ioanarusiczki ioanarusiczki changed the title [Bug]: server error at unreject+reject [Bug]: server error at unreject+reject when a developer appeal is attached with a promoted add-on Jan 31, 2025
@ioanarusiczki
Copy link
Author

Same without a version being promoted , I could reproduce it with a regular add-on too

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635756

@diox
Copy link
Member

diox commented Jan 31, 2025

@diox
Copy link
Member

diox commented Feb 4, 2025

Kind of a weird scenario (reject-unreject-reject) which makes it low priority but we shouldn't 500 in this case.

@ioanarusiczki
Copy link
Author

Yes, reason why I tried that is because I remember I used it while testing with instructions from this document

I sent an appeal for a rejected version from rev tools (version1) to Legal queue
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635815

Forwarded the appeal back to AMO
Tried unreject_ reject instead of Deny appeal and it's a 500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants