[Bug]: Cinder Legal Escalation queue - actions don't seem to have an effect over the extensions

[ioanarusiczki]

What happened?

Followup for #15078 (comment)

STR:

1. An add-on reported for add-on policies
2. Request review from Mozilla Legal and check the DSA report from the report section of reviewer's page. In my case https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/63499
3. From Cinder Legal Escalation open the job sent and choose an action. Possible actions to take content down atm is Acceptable Use - Illegal content. I think all policies from Copyright and trademark.

Result:
content is not disabled. I didn't see any emails sent (to reporter or author in this case)

Another scenario:

1. Request review from Legal for an extension (no abuse report attached)
   https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/634992
2. From Cinder Legal Escalation try: a policy that would take content down
3. Or Try Escalate to AMO (which I don't know if it's supposed to be present here) but should send back the report and flag the version in rev tools.

Result:
Email is not sent to the author about content being disabled on AMO.

3. Another scenario would be with Ignore with "Not enough information" for some add-on with abuse report attached -> no email sent to a reporter. No email sent to the reporter.
   https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/634988#review-actions

What did you expect to happen?

It seems to be a few actions available compared to other cinder moderation queues - not sure what's been discussed but so far disabling content does not seem to work.

Also the report for add-on policies continues to be displayed on the reviewer's page as being "Forwarded". (not sure why)
Flag for HR is removed (that's expected)

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[ioanarusiczki]

Checked today: Override decisions from Legal Escalations - not functional either.

[ioanarusiczki]

Another thing noticed - I'll add it here so I can close #15078

Forwarding appeals with Request review from Mozilla Legal -> in Cinder I see for this extension https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635069 a job created in the Legal Escalations which looks more like a report not an appeal (I've sent it multiple times since the appeal is still displayed into Outstanding DSA related reports to resolve, and I've noticed the previous jobs were automatically closed)

last attempt https://stage.cinder.nonprod.webservices.mozgcp.net/job/a01a670e-4e5d-456d-aa4f-7d120a988a68
an older one https://stage.cinder.nonprod.webservices.mozgcp.net/job/5b0dca2a-f825-4258-9758-9f84cd2f007e

[ioanarusiczki]

I tested today on -stage what's been described here

• The first scenario (add-on reported for violating add-on policies and flagged for HR in rev tools) worked when content has been disabled. I've sent the developer appeal and I've noticed it goes to Cinder T&S Escalations. No idea if that's expected.

https://stage.cinder.nonprod.webservices.mozgcp.net/job/0fad1844-ffee-4564-a654-e1417eeb977b

I also tried to escalate to AMO and I see it's working -> version is flagged for HR in rev tools.

• the second scenario when an add-on is forwarded to Legal without a report attached didn't work when I tried to disabled content with Illegal content policy or copyright takedown https://stage.cinder.nonprod.webservices.mozgcp.net/jobd30a51ce-61ea-470e-9239-0e9be8cac111

Also escalation to AMO didn't work.

• third scenario worked, o report forwarded to Legal and resolved with Not enough information policy is sending the correct email to the reporter.

Also the report for add-on policies continues to be displayed on the reviewer's page as being "Forwarded". (not sure why)

this is no longer reproducible. Outstanding DSA related reports to resolve: is empty after request review from Mozilla Legal.

[eviljeff]

@ioanarusiczki I'm understanding your comment correctly: everything works except for the scenario where an add-on is sent to legal without any associated cinder job. In that scenario, the actions on the job in cinder don't do anything (?)

[ioanarusiczki]

@eviljeff Yes, I tried again with
https://stage.cinder.nonprod.webservices.mozgcp.net/job/2853a9f6-3793-4980-a9a2-0e98c9989c43
and this is on AMO right now https://addons.allizom.org/en-US/firefox/addon/testing-dsa-152555/

or a theme in awaiting review https://reviewers.addons.allizom.org/en-US/reviewers/review/2244541
cinder job is https://stage.cinder.nonprod.webservices.mozgcp.net/job/8120a9d9-bc04-434a-8ba7-f27937e19b7a

I've still to look around and brb with updates.
And once I check #15259 I'll try some regression on stage #15245 (comment)

[ioanarusiczki]

I tried some overrides

Seem to be working. Scenario tested was disable content overriding with Ignore.
Also overriding Ignore with Disable seems to be working (something I did not try with #15246)

I don't think appeals forwarded are working.
I metioned something about repeatedly sending one. That's no longer possible. Yet, I see the version is still flagged for HR after appeal was forwarded
Example https://reviewers.addons.allizom.org/en-US/reviewers/review/2244538
And the Cinder job is https://stage.cinder.nonprod.webservices.mozgcp.net/job/6c3485f3-219a-4933-98f4-5a119456e567 which doesn't seem to be an appeal.

[ioanarusiczki]

I filed #15279 so I can close this issue.