Skip to content

Commit 2eaec54

Browse files
authored
[AE-1142] Include ad client dma in the interaction and request-stats pings (#9)
In preparation for rolling out OHTTP between Desktop FFox and MARS, we need to capture all the ad client's geo fields in all our pings -- specifically the interaction and request-stats ping.
1 parent 3cad719 commit 2eaec54

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

telemetry/glean/metrics.yaml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ ad:
123123
country_code:
124124
type: string
125125
description: >
126-
Country code associated with the client when the ad was requested.
126+
Country code (ISO 3166-1 alpha-2) associated with the client when the ad was requested.
127127
Should not be null.
128128
lifetime: application
129129
send_in_pings:
@@ -141,8 +141,9 @@ ad:
141141
region_code:
142142
type: string
143143
description: >
144-
Region code associated with the client when the ad was requested. May
145-
be null.
144+
Region code (ISO 3166-2 alpha-2) associated with the client when the ad was requested.
145+
Region is also known as Subdivision 1.
146+
May be null.
146147
lifetime: application
147148
send_in_pings:
148149
- interaction
@@ -298,7 +299,7 @@ ad_client:
298299
country_code:
299300
type: string
300301
description: >
301-
Country code (ISO 3166-1 alpha-2 format) associated with the client when the ad was requested.
302+
Country code (ISO 3166-1 alpha-2) associated with the client when the ad was requested.
302303
Should not be null.
303304
lifetime: application
304305
send_in_pings:
@@ -314,7 +315,8 @@ ad_client:
314315
region_code:
315316
type: string
316317
description: >
317-
Region code (ISO 3166-2 format) associated with the client when the ad was requested.
318+
Region code (ISO 3166-2 alpha-2) associated with the client when the ad was requested.
319+
Region is also known as Subdivision 1.
318320
May be null.
319321
lifetime: application
320322
send_in_pings:
@@ -330,11 +332,15 @@ ad_client:
330332
dma_code:
331333
type: string
332334
description: >
333-
Designated Marketing Area code (US only) associated with the client when the ad was requested. DMAs are a pre-defined set of city or metro-level regions.
335+
Designated Marketing Area code (US only) associated with the client when the ad was requested.
336+
DMAs are a set of 210 city or metro-level US regions pre-defined by Nielsen.
337+
DMAs are provided to MARS via MaxMind IP geolocation lookup.
334338
May be null.
335339
lifetime: application
336340
send_in_pings:
341+
- interaction
337342
- provider-request-stats
343+
- request-stats
338344
notification_emails:
339345
- mlifshin@mozilla.com
340346
bugs:

0 commit comments

Comments
 (0)