mar file created on Windows always has path seperator '\' in entries

[duanyao]

The mozilla updater program expects '/' as path seperator in mar file, or the update will fail, even on Windows. However, mar.py always create mar files with path seperator '' on Windows.

I think in this line

info.name = name or os.path.normpath(path)

should be

info.name = name or os.path.normpath(path).replace('\\', '/')

[catlee]

Thanks for the bug report!

How did you discover this? Is there a test we could incorporate into this
project's test suite?

On Mon, Nov 30, 2015 at 7:23 AM, Duan Yao notifications@github.com wrote:

The mozilla updater program expects '/' as path seperator in mar file, or
the update will fail, even on Windows. However, mar.py always create mar
files with path seperator '' on Windows.

I think in this line
https://github.com/mozilla/build-mar/blob/master/mardor/marfile.py#L519

info.name = name or os.path.normpath(path)

should be

info.name = name or os.path.normpath(path).replace('', '/')

—
Reply to this email directly or view it on GitHub
#15.

[duanyao]

I don't have a unit test, but you can reproduce this issue as follow:
On windows, run setup.py install in the source dir;
run mar.py -c a.mar scripts/mar.py;
run mar.py -t a.mar, the output is:

SIZE    MODE    NAME
3379    0666    scripts\mar.py

but the entry name should be scripts/mar.py.

I used mar.py to create mar file for my xulrunner app on windows, however when applying update, updater.exe got confused in ensure_parent_dir() function, which expects / as seperator.

[rail]

We may consider using posixpath instead of os.path.

[catlee]

Does PR #16 fix this issue? I can't verify is extracting these would work properly.

[duanyao]

@catlee Sorry for late response. I confirm that PR #16 works fine with command like mar.py -c a.mar scripts/mar.py case, However, if the command is mar.py -c a.mar scripts\mar.py, the resulting entry name is still scripts\mar.py, not scripts/mar.py. This is because posixpath.normpath doesn't normalize Windows path, i.e. posixpath.normpath('a\\b') == 'a\\b'. I think the more safe approach is posixpath.normpath(path.replace('\\', '/')) or os.path.normpath(path).replace('\\', '/').