You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this an nodejs issue we can solve here in userland?
nodejs/node#27120 - Use the /q flag with cmd.exe in child_process.spawn()
I think it makes sense to add the flag by default here (in cross-spawn), without any option, even if it won't be done by default in Node.js child_process because it prevents a "special" Windows behavior (i.e. printing an extra line like D:\foo\bar>echo hello to the console as the initial output nodejs/node#27120 (comment)).
Node.js core needs to make it optional since some user some time might want to use this Windows-only behavior, but cross-spawn doesn't have that burden.
Execa simply prepends the /q flag to the parsed args like this:
Is this an nodejs issue we can solve here in userland?
nodejs/node#27120 - Use the
/q
flag withcmd.exe
inchild_process.spawn()
I think it makes sense to add the flag by default here (in cross-spawn), without any option, even if it won't be done by default in Node.js child_process because it prevents a "special" Windows behavior (i.e. printing an extra line like
D:\foo\bar>echo hello
to the console as the initial output nodejs/node#27120 (comment)).Node.js core needs to make it optional since some user some time might want to use this Windows-only behavior, but cross-spawn doesn't have that burden.
Execa simply prepends the
/q
flag to the parsedargs
like this:https://github.com/sindresorhus/execa/blob/717d29d539e0bdf1666c1a4bc10fa406d996e7b3/index.js#L28-L56
Referenced issue: sindresorhus/execa#116
The text was updated successfully, but these errors were encountered: