-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme/examples should demonstrate AMQP connection with username/password #9
Comments
irb(main):003:0> puts amqp_node.invoke('gmk-dev-queue', 'hello', 'world')
|
@gregkrsak hey thanks for reaching out. Admittedly I restrict access to my broker to localhost only so auth at that level isn't as pressing of a concern but it should be able to be easily incorporated. The current RJR::Nodes::AMQP initialization will need to be expanded though to accept the username and password to use when connecting to the broker: https://github.com/movitto/rjr/blob/master/lib/rjr/nodes/amqp.rb#L117 Upon initialization we can pass these credentials onto the ruby-amqp gem which rjr is using on the backend: https://github.com/movitto/rjr/blob/master/lib/rjr/nodes/amqp.rb#L65 |
Hey not 100% sure when I'll be able to get to this (have a bunch of high priority items on various backlogs for the next month or two) but created the issue to track it. Of course if you want to see this in sooner feel free to send a PR! :-) Again thanks for the issue, |
Currently, the README.md and examples only show an AMQP connection that appears to be using the default guest account. Could we get more info on how rjr operates with respect to opening connections that require credentials? If I re-create the guest account, my connection works just fine.
The text was updated successfully, but these errors were encountered: