Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unformatted output when possible #17

Open
moshiba opened this issue Oct 7, 2020 · 1 comment
Open

Use unformatted output when possible #17

moshiba opened this issue Oct 7, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@moshiba
Copy link
Owner

moshiba commented Oct 7, 2020

e.g. https://github.com/HsuanTingLu/ansi-escape/blob/de0a162c7e10f43b9b7ec15ab7af088a2a0ad816/aesc/control/cursor.cpp#L31-L36

use std::cout.write() instead
@moshiba moshiba added good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested labels Oct 7, 2020
@moshiba
Copy link
Owner Author

moshiba commented Oct 7, 2020

Problem

some arguments are not character arrays, such as x in https://github.com/HsuanTingLu/ansi-escape/blob/de0a162c7e10f43b9b7ec15ab7af088a2a0ad816/aesc/control/cursor.cpp#L32

should we use formatted output here? (std::cout.write(CSI_expr).operator<<(x).write(down_expr);)
or upgrade to C++17 and use charconv,
or roll out our own formatting helpers

@moshiba moshiba mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moshiba