Skip to content

Commit b6ea64c

Browse files
committed
Merge 947cdfb
2 parents dc11bc7 + 947cdfb commit b6ea64c

3 files changed

Lines changed: 24 additions & 39 deletions

File tree

src/Fame-LazyRelations-Tests/FMLazyRelationTest.class.st

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ FMLazyRelationTest >> testAddToLazyRelation [
6666
self assert: dragon killedBy size equals: 1.
6767
self assert: dragon killedBy anyOne equals: entity.
6868
self assert: entity kills size equals: 3.
69-
self assert: entity kills last identicalTo: dragon.
70-
69+
self assert: entity kills last identicalTo: dragon
7170
]
7271

7372
{ #category : 'tests' }
@@ -86,12 +85,10 @@ FMLazyRelationTest >> testByPassByDirectlyAdding [
8685

8786
dragon := RPGLazyDragon new.
8887

89-
9088
entity kills: { dragon }.
9189

9290
self assert: entity kills size equals: 1.
9391
self assert: entity kills anyOne identicalTo: dragon
94-
9592
]
9693

9794
{ #category : 'tests' }
@@ -105,8 +102,7 @@ FMLazyRelationTest >> testDefaultBehavior [
105102
self assert: dragon killedBy size equals: 1.
106103
self assert: dragon killedBy anyOne equals: entity.
107104
self assert: entity kills size equals: 1.
108-
self assert: entity kills anyOne equals: dragon.
109-
105+
self assert: entity kills anyOne equals: dragon
110106
]
111107

112108
{ #category : 'tests' }
@@ -132,20 +128,18 @@ FMLazyRelationTest >> testManyToOneWithlazyOne [
132128
{ #category : 'tests' }
133129
FMLazyRelationTest >> testOneToManyRelation [
134130

135-
| entity hero |
136-
137-
entity := RPGLazyTalisman new.
138-
hero := RPGLazyHero new.
131+
| entity hero |
132+
entity := RPGLazyTalisman new.
133+
hero := RPGLazyHero new.
139134

140-
FMLazyValue
141-
makeRelation: #owner
142-
of: entity
143-
lazyUsing: [ :rel :entit |
144-
rel value: hero ].
135+
FMLazyValue
136+
makeRelation: #owner
137+
of: entity
138+
lazyUsing: [ :rel :entit | rel value: hero ].
145139

146-
self assert: entity owner identicalTo: hero.
147-
self assert: hero talismans size equals: 1.
148-
self assert: hero talismans anyOne identicalTo: entity.
140+
self assert: entity owner identicalTo: hero.
141+
self assert: hero talismans size equals: 1.
142+
self assert: hero talismans anyOne identicalTo: entity
149143
]
150144

151145
{ #category : 'tests' }

src/Fame-LazyRelations/FMLazyOne.class.st

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,16 @@ Class {
88
{ #category : 'accessing' }
99
FMLazyOne >> materializeFor: anObject slot: aSlot [
1010

11-
| holder value |
12-
13-
holder := FMLazyOneHolder new.
11+
| holder value |
12+
holder := FMLazyOneHolder new.
1413

15-
loader
16-
value: holder
17-
value: anObject.
14+
loader value: holder value: anObject.
1815

19-
value := holder value.
16+
value := holder value.
2017

21-
aSlot
22-
writeMaterialized: value
23-
to: anObject.
18+
aSlot writeMaterialized: value to: anObject.
2419

25-
value ifNotNil: [
26-
aSlot
27-
addAssociationFrom: anObject
28-
to: value ].
20+
value ifNotNil: [ aSlot addAssociationFrom: anObject to: value ].
2921

30-
^ value
22+
^ value
3123
]

src/Fame-LazyRelations/FMLazyValue.class.st

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"
22
I am an uninitialized relation.
3-
When first accessed, I relsolved my loader block
3+
When first accessed, my `loader` block is evaluated.
44
"
55
Class {
66
#name : 'FMLazyValue',
@@ -38,9 +38,8 @@ FMLazyValue class >> makeRelation: aSymbol of: anEntity lazyUsing: aBlock [
3838

3939
{ #category : 'accessing' }
4040
FMLazyValue >> fmValueReadFrom: aSlot owner: anObject [
41-
^ self
42-
materializeFor: anObject
43-
slot: aSlot
41+
42+
^ self materializeFor: anObject slot: aSlot
4443
]
4544

4645
{ #category : 'accessing' }
@@ -50,9 +49,9 @@ FMLazyValue >> loader [
5049
]
5150

5251
{ #category : 'accessing' }
53-
FMLazyValue >> loader: anObject [
52+
FMLazyValue >> loader: aBlock [
5453

55-
loader := anObject
54+
loader := aBlock
5655
]
5756

5857
{ #category : 'accessing' }

0 commit comments

Comments
 (0)