Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VS Code] findMoonBin mishandles home directory path ("~") #80

Open
patrik-simunic-cz opened this issue Feb 19, 2025 · 1 comment
Open

[VS Code] findMoonBin mishandles home directory path ("~") #80

patrik-simunic-cz opened this issue Feb 19, 2025 · 1 comment

Comments

@patrik-simunic-cz
Copy link

When the VS Code setting moon.binPath starts with a tilde (~), then Workspace.findMoonBin method mishandles this path as it treats it as a "regular" relative path and prepends a root path to it.

For example
~/.proto/shims/moon becomes /Users/patrik/projects/foo/~/.proto/shims/moon
@patrik-simunic-cz patrik-simunic-cz mentioned this issue Feb 19, 2025
Open
@patrik-simunic-cz patrik-simunic-cz changed the title [VSCode extension] findMoonBin mishandles home directory path ("~") [VS Code] findMoonBin mishandles home directory path ("~") Feb 19, 2025
@patrik-simunic-cz
Copy link
Author

Opened a PR: #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrik-simunic-cz