Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standard deviation metrics #179

Open
unkrich opened this issue Apr 13, 2022 · 0 comments
Open

Fix standard deviation metrics #179

unkrich opened this issue Apr 13, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@unkrich
Copy link
Collaborator

unkrich commented Apr 13, 2022

Description

Numeric standard deviation and length standard deviation are not currently being calculated

https://github.com/monosidev/monosi/blob/master/src/ingestion/sources/base.py#L265-L275

Expected behavior

By uncommenting these lines, we would expect that the metrics are made available to users. It would seem that the SQL being run in this case is not correctly computing the standard deviation of length and values.

The current SQL is here:

Steps to reproduce

  1. Uncomment https://github.com/monosidev/monosi/blob/master/src/ingestion/sources/base.py#L265-L275 to enable the metrics. 2. Then try to run the application.
  2. You'll notice that queries fail due to the metric being calculated incorrectly.
    There is also the potential that it works and there is some specific niche case where this was an issue, so this should be verified.

Additional context

To fix this issue, one simply needs to figure out the SQL required to calculate the numeric std dev and length std dev and replace the fields here. Then, uncomment the metric lines.

@unkrich unkrich added the good first issue Good for newcomers label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant