Skip to content

Update to latest nunit #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joelmartinez opened this issue Jul 9, 2018 · 5 comments
Closed

Update to latest nunit #284

joelmartinez opened this issue Jul 9, 2018 · 5 comments
Assignees
Milestone

Comments

@joelmartinez
Copy link
Member

per #246 ... which tried to make a number of changes at the same time, and resulted in some tests not passing. Let's update nunit, so that it's not a problem when we subsequently make the other project/nuget changes

@ChrisMaddock
Copy link

Great to see this issue logged. 🙂 You should be aware of @wachulski's project below, which will help with some of the heavy lifting!

https://github.com/wachulski/nunit-migrator

@joelmartinez
Copy link
Member Author

Whoa, this is great @ChrisMaddock ... thanks for the heads up on this!

@ChrisMaddock
Copy link

No worries! I had a quick look at #246 and saw some of the problems you hit previously - looks like you'll need to be aware of the path changes described below:

https://github.com/nunit/docs/wiki/Breaking-Changes

I did also pull the repo to have a quick bash, but wasn't able to get a clean build - should the solution build straight out of the box in VS on Windows? Anyway...I'm all out of lunch break now! 😄

Let us know if you hit any other stumbling blocks. 🙂

@joelmartinez joelmartinez modified the milestones: mdoc 5.7.3, mdoc 5.7.4 Aug 21, 2018
@joelmartinez
Copy link
Member Author

@ChrisMaddock I know this was a bit ago, but I'm going to start working on this in the next release. You mentioned you had issues building on VSWin, was it by chance similar to the issue(s) described here?
#308

@joelmartinez joelmartinez self-assigned this Aug 21, 2018
@ChrisMaddock
Copy link

ChrisMaddock commented Aug 21, 2018

@joelmartinez - it was a while ago now, but yes - I had problems with the same packages. I think I also did a work around, then hit further problems, and at that point ran out of lunch break!

Good luck with the NUnit upgrade - should if we can help with anything!

joelmartinez added a commit that referenced this issue Aug 23, 2018
@joelmartinez joelmartinez modified the milestones: mdoc 5.7.4, mdoc 5.7.3.1 Aug 27, 2018
joelmartinez added a commit that referenced this issue Aug 30, 2018
joelmartinez added a commit that referenced this issue Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants