Skip to content

Improve internal handling of hooks from different locations #53

Open
@monkeyman192

Description

@monkeyman192

Currently the system that handles hook collisions internally is by associating a hook with the name. If multiple mods define hooks for the same function with different name we'll get an error from minhook which will seem reasonably cryptic.

The system should be changed internally to instead use the absolute resolved address to disambiguate hooks.
If multiple hooks end up being defined with different func def's then we need to detect this and raise a warning that there are differing funcdef's for the same function and that only the first defined one will be used.
This comparison will need to take into account ctypes.c_uint64 == ctypes.c_ulonglong for example.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    Status

    No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions