[Bug]: mongodbatlas_project_ip_access_list resource gets automatically imported to TF state if it already exists

[alacasse25]

Is there an existing issue for this?

• I have searched the existing issues

Provider Version

2.1.0

Terraform Version

v1.8.5

Terraform Edition

Terraform Open Source (OSS)

Current Behavior

Hey guys,

We recently had an issue where we accidently deleted the IP whitelist of our MongoDB project by tearing down an old environment. Later down the road, we found out that all of our TF states were referencing the exact same mongodbatlas_project_ip_access_list resource. Our environments were creating the resource on the same project and the resource got automatically imported into each of their TF states. We weren't aware of the behavior and were quite surprised that we didn't get a 409 instead.

For example, when doing the same manipulations as described below, but on a mongodbatlas_database_user resource we get the following error: POST: HTTP 409 Conflict (Error code: "USER_ALREADY_EXISTS") which is what we would have expected from the mongodbatlas_project_ip_access_list resource.

Thanks for the help :)

Terraform configuration to reproduce the issue

resource "mongodbatlas_project_ip_access_list" "whitelist_all" {
  project_id = "your_mongodb_project_id"
  cidr_block = "0.0.0.0/0"
}

Steps To Reproduce

1. Create a blank project that will only manage a mongodbatlas_project_ip_access_list resource
2. TF apply
3. Delete your TF state
4. Rerun the TF apply
5. The resource will be added to your TF state even if it was already existing
   • We would have expected a 409.

Logs

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thanks for opening this issue! Please make sure you've followed our guidelines when opening the issue. In short, to help us reproduce the issue we need:

• Terraform configuration file used to reproduce the issue
• Terraform log files from the run where the issue occurred
• Terraform Atlas provider version used to reproduce the issue
• Terraform version used to reproduce the issue
• Confirmation if Terraform OSS, Terraform Cloud, or Terraform Enterprise deployment

The ticket CLOUDP-353938 was created for internal tracking.

[AgustinBettati]

Hi @alacasse25. Thank you for raising this issue.

The incorrect behaviour present in mongodbatlas_project_ip_access_list is associated to how the underlying API is currently handling creation of duplicate ip access entries. We are working internally to handle this validation, however it will not be a quick change.

While we progress towards a solution we will still add a note in our documentation to be clear on the existing limitation (#3823).

[alacasse25]

Hi @AgustinBettati,

Thanks for the explanations and for updating the documentation. I suppose it might prevent others from having the same issue as we did while the validation is added.

Have a nice day.

[github-actions]

This issue has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!